From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH v6 3/6] livepatch: NOP if func->new_addr is
	zero.
Date: Mon, 19 Sep 2016 13:02:33 -0400
Message-ID: <20160919170233.GC30790@localhost.localdomain>
References: <1474039754-25816-1-git-send-email-konrad.wilk@oracle.com>
 <1474039754-25816-4-git-send-email-konrad.wilk@oracle.com>
 <57DFC514020000780010FDBF@prv-mh.provo.novell.com>
 <20160919161158.GC9860@localhost.localdomain>
 <57E02EFB020000780011041A@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
 by lists.xenproject.org with esmtp (Exim 4.84_2)
 (envelope-from <konrad.wilk@oracle.com>) id 1bm1xw-0004T8-A6
 for xen-devel@lists.xenproject.org; Mon, 19 Sep 2016 17:02:48 +0000
Content-Disposition: inline
In-Reply-To: <57E02EFB020000780011041A@prv-mh.provo.novell.com>
List-Unsubscribe: <https://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <https://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: Jan Beulich <JBeulich@suse.com>
Cc: andrew.cooper3@citrix.com, xen-devel@lists.xenproject.org, ross.lagerwall@citrix.com
List-Id: xen-devel@lists.xenproject.org

T24gTW9uLCBTZXAgMTksIDIwMTYgYXQgMTA6MzE6MjNBTSAtMDYwMCwgSmFuIEJldWxpY2ggd3Jv
dGU6Cj4gPj4+IE9uIDE5LjA5LjE2IGF0IDE4OjExLCA8a29ucmFkLndpbGtAb3JhY2xlLmNvbT4g
d3JvdGU6Cj4gPiBPbiBNb24sIFNlcCAxOSwgMjAxNiBhdCAwMjo1OTozMkFNIC0wNjAwLCBKYW4g
QmV1bGljaCB3cm90ZToKPiA+PiA+Pj4gT24gMTYuMDkuMTYgYXQgMTc6MjksIDxrb25yYWQud2ls
a0BvcmFjbGUuY29tPiB3cm90ZToKPiA+PiA+IEBAIC0zMSwxMSArMzAsMTEgQEAgdm9pZCBhcmNo
X2xpdmVwYXRjaF9yZXZpdmUodm9pZCkKPiA+PiA+ICAKPiA+PiA+ICBpbnQgYXJjaF9saXZlcGF0
Y2hfdmVyaWZ5X2Z1bmMoY29uc3Qgc3RydWN0IGxpdmVwYXRjaF9mdW5jICpmdW5jKQo+ID4+ID4g
IHsKPiA+PiA+IC0gICAgLyogTm8gTk9QIHBhdGNoaW5nIHlldC4gKi8KPiA+PiA+IC0gICAgaWYg
KCAhZnVuYy0+bmV3X3NpemUgKQo+ID4+ID4gKyAgICAvKiBJZiBOT1Bpbmcgb25seSBkbyB1cCB0
byBtYXhpbXVtIGFtb3VudCB3ZSBjYW4gcHV0IGluIHRoZSAtPm9wYXF1ZS4gKi8KPiA+PiA+ICsg
ICAgaWYgKCAhZnVuYy0+bmV3X2FkZHIgJiYgZnVuYy0+bmV3X3NpemUgPiBzaXplb2YoZnVuYy0+
b3BhcXVlKSApCj4gPj4gPiAgICAgICAgICByZXR1cm4gLUVPUE5PVFNVUFA7Cj4gPj4gPiAgCj4g
Pj4gPiAtICAgIGlmICggZnVuYy0+b2xkX3NpemUgPCBQQVRDSF9JTlNOX1NJWkUgKQo+ID4+ID4g
KyAgICBpZiAoIGZ1bmMtPm9sZF9zaXplIDwgQVJDSF9QQVRDSF9JTlNOX1NJWkUgKQo+ID4+ID4g
ICAgICAgICAgcmV0dXJuIC1FSU5WQUw7Cj4gPj4gCj4gPj4gSXMgdGhhdCBpbmRlZWQgYSByZXF1
aXJlbWVudCB3aGVuIE5PUGluZz8gWW91IGNhbiBlYXNpbHkgTk9QIG91dAo+ID4+IGp1c3QgYSBz
aW5nbGUgYnl0ZSBvbiB4ODYuIE9yIHNob3VsZG4ndCBpbiB0aGF0IGNhc2Ugb2xkX3NpemUgPT0g
bmV3X3NpemUKPiA+PiBhbnl3YXk/IEluIHdoaWNoIGNhc2UgdGhlIGNvbW1lbnQgZnVydGhlciBk
b3duIHN0YXRpbmcgdGhhdCBuZXdfc2l6ZQo+ID4gCj4gPiBUaGUgb3JpZ2luYWwgaW50ZW50IGJl
aGluZCAub2xkX3NpemUgd2FzIHRvIGd1YXJkIGFnYWluc3QgcGF0Y2hpbmcKPiA+IGZ1bmN0aW9u
cyB0aGF0IHdlcmUgbGVzcyB0aGFuIG91ciByZWxhdGl2ZSBqdW1wLiAKPiA+IAo+ID4gKFRoZSB0
b29scyBlbmQgdXAgY29tcHV0aW5nIHRoZSAub2xkX3NpemUgYXMgdGhlIHNpemUgb2YgdGhlIHdo
b2xlIGZ1bmN0aW9uCj4gPiB3aGljaCBpcyBmaW5lKS4KPiA+IAo+ID4gQnV0IHdpdGggdGhpcyBO
T1Bpbmcgc3VwcG9ydCwgeW91IGFyZSByaWdodCAtIHdlIGNvdWxkIGhhdmUgbm93IGFuCj4gPiBm
dW5jdGlvbiB0aGF0IGlzIHNheSA0IGJ5dGVzIGxvbmcgYW5kIHdlIG9ubHkgbmVlZCB0byBOT1Ag
dGhyZWUgYnl0ZXMKPiA+IG91dCBvZiBpdCAodGhlIGxhc3QgaW5zdHJ1Y3Rpb24gSSBhc3N1bWUg
d291bGQgYmUgJ3JldCcpLgo+ID4gCj4gPiBTbyBwZXJoYXBzIHRoaXMgY2hlY2sgbmVlZHMganVz
dCBuZWVkcyBhbiAnZWxzZSBpZicgLCBsaWtlIHNvOgo+ID4gCj4gPiBpbnQgYXJjaF9saXZlcGF0
Y2hfdmVyaWZ5X2Z1bmMoY29uc3Qgc3RydWN0IGxpdmVwYXRjaF9mdW5jICpmdW5jKQo+ID4gewo+
ID4gICAgIC8qIElmIE5PUGluZy4uICovCj4gPiAgICAgaWYgKCAhZnVuYy0+bmV3X2FkZHIgKQo+
ID4gICAgIHsKPiA+ICAgICAgICAgLyogT25seSBkbyB1cCB0byBtYXhpbXVtIGFtb3VudCB3ZSBj
YW4gcHV0IGluIHRoZSAtPm9wYXF1ZS4gKi8KPiA+ICAgICAgICAgaWYgKCBmdW5jLT5uZXdfc2l6
ZSA+IHNpemVvZihmdW5jLT5vcGFxdWUpICkKPiA+ICAgICAgICAgICAgIHJldHVybiAtRU9QTk9U
U1VQUDsKPiA+IAo+ID4gICAgICAgICAvKiBPbmUgaW5zdHJ1Y3Rpb24gZm9yICdyZXQnIGFuZCB0
aGUgb3RoZXIgdG8gTk9QLiAqLwo+ID4gICAgICAgICBpZiAoIGZ1bmMtPm9sZF9zaXplIDwgMiAp
Cj4gPiAgICAgICAgICAgICByZXR1cm4gLUVJTlZBTDsKPiA+ICAgICB9Cj4gPiAgICAgZWxzZSBp
ZiAoIGZ1bmMtPm9sZF9zaXplIDwgQVJDSF9QQVRDSF9JTlNOX1NJWkUgKQo+ID4gICAgICAgICBy
ZXR1cm4gLUVJTlZBTDsKPiA+IAo+ID4gICAgIHJldHVybiAwOwo+ID4gfQo+IAo+IEV4Y2VwdCB0
aGF0IEkgd291bGRuJ3QgdXNlIDIsIHRvIG5vdCBleGNsdWRlIHBhdGNoaW5nIG91dCBzb21lCj4g
c2luZ2xlIGJ5dGUgaW4gdGhlIG1pZGRsZSBvZiBhIGZ1bmN0aW9uLCB3aXRob3V0IHJlZ2FyZCB0
byB3aGF0IHRoZQo+IGZ1bmN0aW9uJ3MgYWN0dWFsIHNpemUgaXMuCgpVaC11aC4KClRoZSBfbmV3
X3NpemVfIGRldGVybWluZXMgaG93IG1hbnkgYnl0ZXMgdG8gTk9QIChpbiB0aGUgY29udGV4dCBv
Zgp0aGlzIHBhdGNoKS4gVGhlIG9sZF9zaXplICh3aGVyZSB3ZSBjaGVjayB0byBiZSBhdCBtaW4g
MikgaXMgYSBzYWZldHkKdmFsdmUgdG8gbWFrZSBzdXJlIHdlIGRvbid0IE5PUCBzb21ldGhpbmcg
b3V0c2lkZSB0aGUgZnVuY3Rpb24uCgouLnNuaXAuLgo+ID4+IE5PUCBhZGRpdGlvbiBoZXJlLCBw
ZXJoYXBzIHdvcnRoIGRyb3BwaW5nIHRoZSBfam1wIGZyb20gdGhlCj4gPj4gZnVuY3Rpb24gbmFt
ZSAoYW5kIGl0cyByZXZlcnQgY291bnRlcnBhcnQpPwo+ID4gCj4gPiBPb2gsIGdvb2QgaWRlYS4g
QnV0IEkgdGhpbmsgaXQgbWF5YmUgYmV0dGVyIGFzIGEgc2VwZXJhdGUgcGF0Y2ggKGFzIGl0Cj4g
PiBhbHNvIHRvdWNoZXMgdGhlIEFSTSBjb2RlKS4KPiAKPiBUaGF0J3MgaW4gdGhlIG90aGVyIHNl
cmllcywgaXNuJ3QgaXQ/CgpJdCBleHBhbmRzIHRoZSBleGlzdGluZyBvbmVzLiBSaWdodCBub3cg
aW4gJ3N0YWdpbmcnIGJyYW5jaCB3ZSBoYXZlIGFuCmFyY2gvYXJtL2xpdmVwYXRjaC5jIHdoaWNo
IGhhcyB0aGVzZSBmdW5jdGlvbnMgaW4gaXQuCgpHcmFudGVkIG5vdGhpbmcgY29tcGlsZXMgdGhl
bSwgc28gSSBjb3VsZCBicmVhayBpdCBpbiB0aGlzIHBhdGNoLgoKQnV0IEkgYWxyZWFkeSBjb2Ji
bGVkIHVwIHRoZSBwYXRjaCBzbyBtYXkgYXMgd2VsbCB1c2UgaXQ/CgpGcm9tIDQ1YWJkZDZhMGMz
YTZhMmNhNzE4MGM3MzQwMDMyYWM1YjJiMTg2YTQgTW9uIFNlcCAxNyAwMDowMDowMCAyMDAxCkZy
b206IEtvbnJhZCBSemVzenV0ZWsgV2lsayA8a29ucmFkLndpbGtAb3JhY2xlLmNvbT4KRGF0ZTog
TW9uLCAxOSBTZXAgMjAxNiAxMjoyMDoyNyAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIGxpdmVwYXRj
aDogRHJvcCBfam1wIGZyb20gYXJjaF9saXZlcGF0Y2hfW2FwcGx5LHJldmVydF1fam1wCgpXaXRo
ICJsaXZlcGF0Y2g6IE5PUCBpZiBmdW5jLT5uZXdfYWRkciBpcyB6ZXJvLiIgdGhhdCBuYW1lCm1h
a2VzIG5vIG1vcmUgc2Vuc2UuCgpTdWdnZXN0ZWQtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBz
dXNlLmNvbT4KU2lnbmVkLW9mZi1ieTogS29ucmFkIFJ6ZXN6dXRlayBXaWxrIDxrb25yYWQud2ls
a0BvcmFjbGUuY29tPgotLS0Kdjc6IE5ldyBzdWJtaXNzaW9uCi0tLQogeGVuL2FyY2gvYXJtL2xp
dmVwYXRjaC5jICAgIHwgNCArKy0tCiB4ZW4vYXJjaC94ODYvbGl2ZXBhdGNoLmMgICAgfCA0ICsr
LS0KIHhlbi9pbmNsdWRlL3hlbi9saXZlcGF0Y2guaCB8IDQgKystLQogMyBmaWxlcyBjaGFuZ2Vk
LCA2IGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEveGVuL2FyY2gv
YXJtL2xpdmVwYXRjaC5jIGIveGVuL2FyY2gvYXJtL2xpdmVwYXRjaC5jCmluZGV4IDc1NWY1OTYu
LjdmMDY3YTAgMTAwNjQ0Ci0tLSBhL3hlbi9hcmNoL2FybS9saXZlcGF0Y2guYworKysgYi94ZW4v
YXJjaC9hcm0vbGl2ZXBhdGNoLmMKQEAgLTIxLDExICsyMSwxMSBAQCBpbnQgYXJjaF9saXZlcGF0
Y2hfdmVyaWZ5X2Z1bmMoY29uc3Qgc3RydWN0IGxpdmVwYXRjaF9mdW5jICpmdW5jKQogICAgIHJl
dHVybiAtRU5PU1lTOwogfQogCi12b2lkIGFyY2hfbGl2ZXBhdGNoX2FwcGx5X2ptcChzdHJ1Y3Qg
bGl2ZXBhdGNoX2Z1bmMgKmZ1bmMpCit2b2lkIGFyY2hfbGl2ZXBhdGNoX2FwcGx5KHN0cnVjdCBs
aXZlcGF0Y2hfZnVuYyAqZnVuYykKIHsKIH0KIAotdm9pZCBhcmNoX2xpdmVwYXRjaF9yZXZlcnRf
am1wKGNvbnN0IHN0cnVjdCBsaXZlcGF0Y2hfZnVuYyAqZnVuYykKK3ZvaWQgYXJjaF9saXZlcGF0
Y2hfcmV2ZXJ0KGNvbnN0IHN0cnVjdCBsaXZlcGF0Y2hfZnVuYyAqZnVuYykKIHsKIH0KIApkaWZm
IC0tZ2l0IGEveGVuL2FyY2gveDg2L2xpdmVwYXRjaC5jIGIveGVuL2FyY2gveDg2L2xpdmVwYXRj
aC5jCmluZGV4IDExODc3MGUuLjM2YmJjNWYgMTAwNjQ0Ci0tLSBhL3hlbi9hcmNoL3g4Ni9saXZl
cGF0Y2guYworKysgYi94ZW4vYXJjaC94ODYvbGl2ZXBhdGNoLmMKQEAgLTQ3LDcgKzQ3LDcgQEAg
aW50IGFyY2hfbGl2ZXBhdGNoX3ZlcmlmeV9mdW5jKGNvbnN0IHN0cnVjdCBsaXZlcGF0Y2hfZnVu
YyAqZnVuYykKICAgICByZXR1cm4gMDsKIH0KIAotdm9pZCBhcmNoX2xpdmVwYXRjaF9hcHBseV9q
bXAoc3RydWN0IGxpdmVwYXRjaF9mdW5jICpmdW5jKQordm9pZCBhcmNoX2xpdmVwYXRjaF9hcHBs
eShzdHJ1Y3QgbGl2ZXBhdGNoX2Z1bmMgKmZ1bmMpCiB7CiAgICAgdWludDhfdCAqb2xkX3B0cjsK
ICAgICB1aW50OF90IGluc25bc2l6ZW9mKGZ1bmMtPm9wYXF1ZSldOwpAQCAtNzYsNyArNzYsNyBA
QCB2b2lkIGFyY2hfbGl2ZXBhdGNoX2FwcGx5X2ptcChzdHJ1Y3QgbGl2ZXBhdGNoX2Z1bmMgKmZ1
bmMpCiAgICAgbWVtY3B5KG9sZF9wdHIsIGluc24sIGxlbik7CiB9CiAKLXZvaWQgYXJjaF9saXZl
cGF0Y2hfcmV2ZXJ0X2ptcChjb25zdCBzdHJ1Y3QgbGl2ZXBhdGNoX2Z1bmMgKmZ1bmMpCit2b2lk
IGFyY2hfbGl2ZXBhdGNoX3JldmVydChjb25zdCBzdHJ1Y3QgbGl2ZXBhdGNoX2Z1bmMgKmZ1bmMp
CiB7CiAgICAgbWVtY3B5KGZ1bmMtPm9sZF9hZGRyLCBmdW5jLT5vcGFxdWUsIGxpdmVwYXRjaF9p
bnNuX2xlbihmdW5jKSk7CiB9CmRpZmYgLS1naXQgYS94ZW4vaW5jbHVkZS94ZW4vbGl2ZXBhdGNo
LmggYi94ZW4vaW5jbHVkZS94ZW4vbGl2ZXBhdGNoLmgKaW5kZXggMTc0YWYwNi4uYjdmNjZkNCAx
MDA2NDQKLS0tIGEveGVuL2luY2x1ZGUveGVuL2xpdmVwYXRjaC5oCisrKyBiL3hlbi9pbmNsdWRl
L3hlbi9saXZlcGF0Y2guaApAQCAtODYsOCArODYsOCBAQCB1bnNpZ25lZCBpbnQgbGl2ZXBhdGNo
X2luc25fbGVuKGNvbnN0IHN0cnVjdCBsaXZlcGF0Y2hfZnVuYyAqZnVuYykKIGludCBhcmNoX2xp
dmVwYXRjaF9xdWllc2NlKHZvaWQpOwogdm9pZCBhcmNoX2xpdmVwYXRjaF9yZXZpdmUodm9pZCk7
CiAKLXZvaWQgYXJjaF9saXZlcGF0Y2hfYXBwbHlfam1wKHN0cnVjdCBsaXZlcGF0Y2hfZnVuYyAq
ZnVuYyk7Ci12b2lkIGFyY2hfbGl2ZXBhdGNoX3JldmVydF9qbXAoY29uc3Qgc3RydWN0IGxpdmVw
YXRjaF9mdW5jICpmdW5jKTsKK3ZvaWQgYXJjaF9saXZlcGF0Y2hfYXBwbHkoc3RydWN0IGxpdmVw
YXRjaF9mdW5jICpmdW5jKTsKK3ZvaWQgYXJjaF9saXZlcGF0Y2hfcmV2ZXJ0KGNvbnN0IHN0cnVj
dCBsaXZlcGF0Y2hfZnVuYyAqZnVuYyk7CiB2b2lkIGFyY2hfbGl2ZXBhdGNoX3Bvc3RfYWN0aW9u
KHZvaWQpOwogCiB2b2lkIGFyY2hfbGl2ZXBhdGNoX21hc2sodm9pZCk7Ci0tIAoyLjQuMTEKCj4g
Cj4gSmFuCj4gCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
XwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHBzOi8v
bGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK