From: Guenter Roeck <linux@roeck-us.net>
To: Timothy Pearson <tpearson@raptorengineering.com>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] Initial driver for the MAX31785 intelligent fan controller
Date: Mon, 19 Sep 2016 13:04:13 -0700 [thread overview]
Message-ID: <20160919200413.GA29242@roeck-us.net> (raw)
In-Reply-To: <57E03124.4030202@raptorengineeringinc.com>
On Mon, Sep 19, 2016 at 01:40:36PM -0500, Timothy Pearson wrote:
> On 09/18/2016 08:41 PM, Guenter Roeck wrote:
> >> +Sysfs entries
> >> +-------------
> >> +
> >> +fan[1-6]_input RO fan tachometer speed in RPM
> >> +fan[1-6]_fault RO fan experienced fault
> >> +fan[1-6]_target RW desired fan speed in RPM
> >> +fan[1-6]_control_mode RW desired control mode: rpm, pwm, or auto
> >
> > Please use pwm[]_enable (see API)
> >
> >> +pwm[1-6]_enable RW output enabled, 0=disabled, 1=enabled
> >
> > Per API: 0 = no fan speed control (full speed), 1 = manual fan speed control
> > enabled (using pwm[1-*]), 2+: automatic fan speed control
> >
> >> +pwm[1-6] RW fan target duty cycle (0-255)
>
> This particular device has a per-output PWM disable bit. How should
> this be handled? I don't want to globally enable outputs that are not
> connector or may possibly be incorrectly connected depending on hardware
> design.
>
Not sure I understand. pwm[1-6]_enable = 0 means no fan speed control.
Do you mean the (full speed) comment ?
Having said that, looking into the datasheet, I see that this is actually
a PMBus device. Why don't you just write a PMBus extension driver for it ?
AFAICS drivers/hwmon/pmbus/max34440.c would come pretty close and could
possibly even be extended to support this chip.
Guenter
next prev parent reply other threads:[~2016-09-19 20:04 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 1:41 [PATCH] Initial driver for the MAX31785 intelligent fan controller Guenter Roeck
2016-09-19 18:14 ` Timothy Pearson
2016-09-19 20:05 ` Guenter Roeck
2016-09-19 18:40 ` Timothy Pearson
2016-09-19 20:04 ` Guenter Roeck [this message]
2016-09-19 20:31 ` Timothy Pearson
2016-09-20 0:54 ` Guenter Roeck
2016-09-20 1:41 ` Timothy Pearson
2016-09-20 19:41 ` Timothy Pearson
2016-09-20 19:59 ` Guenter Roeck
2016-09-20 20:01 ` Timothy Pearson
2016-09-21 3:04 ` Guenter Roeck
2016-09-21 3:09 ` Timothy Pearson
2016-10-11 14:39 ` Timothy Pearson
-- strict thread matches above, loose matches on Subject: below --
2016-09-20 1:52 [PATCH] Add hwmon driver for MAX31875 Timothy Pearson
2016-09-20 1:52 ` [PATCH] Initial driver for the MAX31785 intelligent fan controller Timothy Pearson
2016-09-23 7:41 ` Joel Stanley
2016-09-23 15:04 ` Timothy Pearson
2016-12-09 15:55 ` Matt Spinler
2016-12-11 23:36 ` Joel Stanley
2016-12-12 16:32 ` Timothy Pearson
2016-12-12 18:17 ` Matt Spinler
2016-12-12 19:56 ` Timothy Pearson
2016-09-19 0:50 Timothy Pearson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160919200413.GA29242@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-hwmon@vger.kernel.org \
--cc=tpearson@raptorengineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.