All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josh Triplett <josh@joshtriplett.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Andrew Donnellan <andrew.donnellan@au1.ibm.com>,
	git@vger.kernel.org, Jeff King <peff@peff.net>
Subject: Re: [PATCH v2] format-patch: Add --rfc for the common case of [RFC PATCH]
Date: Mon, 19 Sep 2016 13:44:08 -0700	[thread overview]
Message-ID: <20160919204408.GA28962@cloud> (raw)
In-Reply-To: <xmqqa8f3g4pu.fsf@gitster.mtv.corp.google.com>

On Mon, Sep 19, 2016 at 10:49:17AM -0700, Junio C Hamano wrote:
> Andrew Donnellan <andrew.donnellan@au1.ibm.com> writes:
> 
> > Sounds good to me. Agreed that "RFC" is essentially the only prefix
> > other than "PATCH" that I see, at least in the kernel.
> 
> Around here I think we saw WIP too, and that makes me lean towards
> Peff's earlier suggestion to allow an end-user supplied string in
> front of PATCH, i.e. "-P RFC" => "--subject-prefix='RFC PATCH'",
> even though I understand that those who _ONLY_ care about RFC would
> prefer --rfc (5 keystrokes) over "-P RFC" (6 keystrokes).

I do share the concern raised elsewhere in the thread that adding new
format-patch short options potentially conflicts with diff/rev-list
short options.  If you're not worried about that, I'd be happy to add
(and document and test) -P.  However, I'd still advocate adding --rfc as
well; it's a common case, and "-P RFC" is actually rather more
keystrokes when you count shifting. :)

There might also be some value in steering people towards "RFC" (since a
WIP is in a way an RFC).

> >> +--rfc::
> >> +	Alias for `--subject-prefix="RFC PATCH"`. Use this when
> >> +	sending an experimental patch for discussion rather than
> >> +	application.
> >
> > Perhaps mention the phrase "Request For Comment" for the benefit of
> > those who aren't familiar ...
> 
> Good point.

I'll add that to the documentation in v3.

  reply	other threads:[~2016-09-19 20:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-17  7:21 [PATCH v2] format-patch: Add --rfc for the common case of [RFC PATCH] Josh Triplett
2016-09-17 18:43 ` Jeff King
2016-09-19  9:17 ` Andrew Donnellan
2016-09-19 17:49   ` Junio C Hamano
2016-09-19 20:44     ` Josh Triplett [this message]
2016-09-19 23:34       ` Jeff King
2016-09-19 23:40         ` Josh Triplett
2016-09-19 23:46           ` Jacob Keller
2016-09-19 23:55             ` Josh Triplett
2016-09-19 23:57               ` Jacob Keller
2016-09-20  1:37               ` Jeff King
2016-09-20  1:37           ` Jeff King
2016-09-20  6:50             ` Jacob Keller
2016-09-19 23:44         ` Jacob Keller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160919204408.GA28962@cloud \
    --to=josh@joshtriplett.org \
    --cc=andrew.donnellan@au1.ibm.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.