From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36103) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bm8By-0006wY-Qh for qemu-devel@nongnu.org; Mon, 19 Sep 2016 19:41:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bm8Bt-0004Rr-Qh for qemu-devel@nongnu.org; Mon, 19 Sep 2016 19:41:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44032) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bm8Bt-0004Rn-KU for qemu-devel@nongnu.org; Mon, 19 Sep 2016 19:41:37 -0400 Date: Tue, 20 Sep 2016 02:41:34 +0300 From: "Michael S. Tsirkin" Message-ID: <20160920024120-mutt-send-email-mst@kernel.org> References: <1474273955-73083-1-git-send-email-imammedo@redhat.com> <1474273955-73083-3-git-send-email-imammedo@redhat.com> <20160919165848.GU6002@thinpad.lan.raisama.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160919165848.GU6002@thinpad.lan.raisama.net> Subject: Re: [Qemu-devel] [PATCH v2 2/3] target-i386: turn off CPU.l3-cache only for 2.7 and older machine types List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Igor Mammedov , qemu-devel@nongnu.org, longpeng2@huawei.com, marcel@redhat.com On Mon, Sep 19, 2016 at 01:58:48PM -0300, Eduardo Habkost wrote: > On Mon, Sep 19, 2016 at 10:32:34AM +0200, Igor Mammedov wrote: > > commit (14c985cff target-i386: present virtual L3 cache info for vcpus) > > misplaced compat property putting it in new 2.8 machine type > > which would effectively to disable feature until 2.9 is released. > > Intent of commit probably should be to disable feature for 2.7 > > and older while allowing not yet released 2.8 to have feature > > enabled by default. > > > > Signed-off-by: Igor Mammedov > > Reviewed-by: Marcel Apfelbaum > > --- > > include/hw/i386/pc.h | 7 +++---- > > 1 file changed, 3 insertions(+), 4 deletions(-) > > > > diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h > > index b0a61f3..29a6c9b 100644 > > --- a/include/hw/i386/pc.h > > +++ b/include/hw/i386/pc.h > > @@ -367,16 +367,15 @@ int e820_get_num_entries(void); > > bool e820_get_entry(int, uint32_t, uint64_t *, uint64_t *); > > > > #define PC_COMPAT_2_8 \ > > PC_COMPAT_2_8 isn't even used by any code (and shouldn't be used > until we release QEMU 2.8). Let's just delete it by now? it's unrelated to this patch though. > > + > > +#define PC_COMPAT_2_7 \ > > + HW_COMPAT_2_7 \ > > {\ > > .driver = TYPE_X86_CPU,\ > > .property = "l3-cache",\ > > .value = "off",\ > > }, > > > > - > > -#define PC_COMPAT_2_7 \ > > - HW_COMPAT_2_7 > > - > > #define PC_COMPAT_2_6 \ > > HW_COMPAT_2_6 \ > > {\ > > -- > > 2.7.4 > > > > -- > Eduardo