From: Dan Carpenter <dan.carpenter@oracle.com>
To: Brian Masney <masneyb@onstation.org>
Cc: gregkh@linuxfoundation.org, linux-iio@vger.kernel.org,
devel@driverdev.osuosl.org
Subject: Re: [PATCH 2/2] staging: iio: isl29018: fix alignment of function arguments
Date: Tue, 20 Sep 2016 13:08:35 +0300 [thread overview]
Message-ID: <20160920100835.GI13620@mwanda> (raw)
In-Reply-To: <1474364337-13949-2-git-send-email-masneyb@onstation.org>
On Tue, Sep 20, 2016 at 05:38:57AM -0400, Brian Masney wrote:
> Address warning from checkpatch:
>
> CHECK: Alignment should match open parenthesis
>
> Signed-off-by: Brian Masney <masneyb@onstation.org>
> ---
> drivers/staging/iio/light/isl29018.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/iio/light/isl29018.c b/drivers/staging/iio/light/isl29018.c
> index ea4d7f1..4401451 100644
> --- a/drivers/staging/iio/light/isl29018.c
> +++ b/drivers/staging/iio/light/isl29018.c
> @@ -607,8 +607,8 @@ static int isl29018_chip_init(struct isl29018_chip *chip)
> return status;
> }
>
> - status = isl29018_set_integration_time(chip,
> - isl29018_int_utimes[chip->type][chip->int_time]);
> + status = isl29018_set_integration_time(
> + chip, isl29018_int_utimes[chip->type][chip->int_time]);
Congrats on finding a hack to silence checkpatch but this doesn't really
improve the code at all... It's ok to ignore checkpatch.pl.
regards,
dan carpenter
prev parent reply other threads:[~2016-09-20 10:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 9:38 [PATCH 1/2] staging: iio: isl29018: remove the FSF's mailing address Brian Masney
2016-09-20 9:38 ` [PATCH 2/2] staging: iio: isl29018: fix alignment of function arguments Brian Masney
2016-09-20 10:08 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160920100835.GI13620@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-iio@vger.kernel.org \
--cc=masneyb@onstation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.