From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gustavo Padovan Subject: Re: [PATCH] dma-buf/sw_sync: mark sync_timeline_create() static Date: Tue, 20 Sep 2016 13:13:38 +0200 Message-ID: <20160920111338.GE13275@joana> References: <1474202961-10099-1-git-send-email-baoyou.xie@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by gabe.freedesktop.org (Postfix) with ESMTPS id E9CB56E71E for ; Tue, 20 Sep 2016 11:13:41 +0000 (UTC) Received: by mail-wm0-f67.google.com with SMTP id 133so2837144wmq.2 for ; Tue, 20 Sep 2016 04:13:41 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1474202961-10099-1-git-send-email-baoyou.xie@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Baoyou Xie Cc: arnd@arndb.de, xie.baoyou@zte.com.cn, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org MjAxNi0wOS0xOCBCYW95b3UgWGllIDxiYW95b3UueGllQGxpbmFyby5vcmc+OgoKPiBXZSBnZXQg MSB3YXJuaW5nIHdoZW4gYnVpbGRpbmcga2VybmVsIHdpdGggVz0xOgo+IGRyaXZlcnMvZG1hLWJ1 Zi9zd19zeW5jLmM6ODc6MjM6IHdhcm5pbmc6IG5vIHByZXZpb3VzIHByb3RvdHlwZSBmb3IgJ3N5 bmNfdGltZWxpbmVfY3JlYXRlJyBbLVdtaXNzaW5nLXByb3RvdHlwZXNdCj4gCj4gSW4gZmFjdCwg dGhpcyBmdW5jdGlvbiBpcyBvbmx5IHVzZWQgaW4gdGhlIGZpbGUgaW4gd2hpY2ggaXQgaXMKPiBk ZWNsYXJlZCBhbmQgZG9uJ3QgbmVlZCBhIGRlY2xhcmF0aW9uLCBidXQgY2FuIGJlIG1hZGUgc3Rh dGljLgo+IFNvIHRoaXMgcGF0Y2ggbWFya3MgaXQgJ3N0YXRpYycuCj4gCj4gU2lnbmVkLW9mZi1i eTogQmFveW91IFhpZSA8YmFveW91LnhpZUBsaW5hcm8ub3JnPgo+IC0tLQo+ICBkcml2ZXJzL2Rt YS1idWYvc3dfc3luYy5jIHwgMiArLQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyks IDEgZGVsZXRpb24oLSkKClRoYW5rcyBmb3IgZmluZGluZyB0aGlzLgoKUmV2aWV3ZWQtYnk6IEd1 c3Rhdm8gUGFkb3ZhbiA8Z3VzdGF2by5wYWRvdmFuQGNvbGxhYm9yYS5jby51az4KCkd1c3Rhdm8K Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZl bCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wm0-f65.google.com ([74.125.82.65]:33118 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752924AbcITLNl (ORCPT ); Tue, 20 Sep 2016 07:13:41 -0400 Date: Tue, 20 Sep 2016 13:13:38 +0200 From: Gustavo Padovan To: Baoyou Xie Cc: sumit.semwal@linaro.org, arnd@arndb.de, xie.baoyou@zte.com.cn, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-media@vger.kernel.org Subject: Re: [PATCH] dma-buf/sw_sync: mark sync_timeline_create() static Message-ID: <20160920111338.GE13275@joana> References: <1474202961-10099-1-git-send-email-baoyou.xie@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1474202961-10099-1-git-send-email-baoyou.xie@linaro.org> Sender: linux-media-owner@vger.kernel.org List-ID: 2016-09-18 Baoyou Xie : > We get 1 warning when building kernel with W=1: > drivers/dma-buf/sw_sync.c:87:23: warning: no previous prototype for 'sync_timeline_create' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which it is > declared and don't need a declaration, but can be made static. > So this patch marks it 'static'. > > Signed-off-by: Baoyou Xie > --- > drivers/dma-buf/sw_sync.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks for finding this. Reviewed-by: Gustavo Padovan Gustavo