From: Stephen Hemminger <stephen@networkplumber.org>
To: Vladyslav Buslov <vladyslav.buslov@harmonicinc.com>
Cc: <ferruh.yigit@intel.com>, <dev@dpdk.org>
Subject: Re: [PATCH] kni: add support for core_id param in single threaded mode
Date: Tue, 20 Sep 2016 11:36:36 -0700 [thread overview]
Message-ID: <20160920113636.38b2ed2a@xeon-e3> (raw)
In-Reply-To: <20160920181637.26778-1-vladyslav.buslov@harmonicinc.com>
On Tue, 20 Sep 2016 21:16:37 +0300
Vladyslav Buslov <vladyslav.buslov@harmonicinc.com> wrote:
> @@ -123,6 +125,9 @@ static int __net_init kni_init_net(struct net *net)
> /* Clear the bit of device in use */
> clear_bit(KNI_DEV_IN_USE_BIT_NUM, &knet->device_in_use);
>
> + mutex_init(&knet->kni_kthread_lock);
> + knet->kni_kthread = NULL;
> +
Why not just use kzalloc() here? You would still need to init the mutex
etc, but it would be safer.
next prev parent reply other threads:[~2016-09-20 18:36 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 11:25 [PATCH] add support for core_id param in single threaded mode Vladyslav Buslov
2016-09-06 11:25 ` [PATCH] kni: " Vladyslav Buslov
2016-09-06 14:14 ` Ferruh Yigit
2016-09-06 14:22 ` Ferruh Yigit
2016-09-06 14:30 ` Ferruh Yigit
2016-09-06 14:38 ` Vladyslav Buslov
2016-09-10 13:50 ` [PATCH v2 1/2] " Vladyslav Buslov
2016-09-10 13:50 ` [PATCH v2 2/2] " Vladyslav Buslov
2016-09-12 17:08 ` Ferruh Yigit
2016-09-13 10:57 ` Vladyslav Buslov
2016-09-20 18:16 ` [PATCH] " Vladyslav Buslov
2016-09-20 18:36 ` Stephen Hemminger [this message]
2016-09-21 16:49 ` Ferruh Yigit
2016-09-21 17:15 ` Vladyslav Buslov
2016-09-21 18:23 ` Ferruh Yigit
2016-09-21 23:44 ` Stephen Hemminger
2016-09-22 9:29 ` Vladyslav Buslov
2016-09-22 15:47 ` Ferruh Yigit
2016-09-21 14:38 ` Ferruh Yigit
2016-09-24 13:13 ` Vladyslav Buslov
2016-09-26 13:58 ` Ferruh Yigit
2016-10-13 20:24 ` Thomas Monjalon
-- strict thread matches above, loose matches on Subject: below --
2016-08-25 14:46 [PATCH] kni: add module parameter 'bind_to_core' Ferruh Yigit
2016-09-02 15:13 ` [PATCH] kni: add support for core_id param in single threaded mode Vladyslav Buslov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160920113636.38b2ed2a@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=vladyslav.buslov@harmonicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.