From: "Tomáš Golembiovský" <tgolembi@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 1/2] qemu-nbd: Shrink image size by specified offset
Date: Tue, 20 Sep 2016 11:37:59 +0200 [thread overview]
Message-ID: <20160920113759.23a1ee06@fiorina> (raw)
When --offset is set the apparent device size has to be adjusted
accordingly. Otherwise client may request read/write beyond the file end
which would fail.
Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com>
---
qemu-nbd.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/qemu-nbd.c b/qemu-nbd.c
index 99297a5..629bce1 100644
--- a/qemu-nbd.c
+++ b/qemu-nbd.c
@@ -901,6 +901,13 @@ int main(int argc, char **argv)
exit(EXIT_FAILURE);
}
+ if (dev_offset >= fd_size) {
+ error_report("Offset (%lu) has to be smaller than the image size (%lu)",
+ dev_offset, fd_size);
+ exit(EXIT_FAILURE);
+ }
+ fd_size -= dev_offset;
+
if (partition != -1) {
ret = find_partition(blk, partition, &dev_offset, &fd_size);
if (ret < 0) {
--
2.9.3
next reply other threads:[~2016-09-20 9:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 9:37 Tomáš Golembiovský [this message]
2016-09-20 9:59 ` [Qemu-devel] [PATCH 1/2] qemu-nbd: Shrink image size by specified offset Paolo Bonzini
2016-09-20 14:09 ` Eric Blake
2016-10-03 13:50 ` Tomáš Golembiovský
2016-10-03 15:12 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160920113759.23a1ee06@fiorina \
--to=tgolembi@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.