From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40186) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmJyL-0006de-Cb for qemu-devel@nongnu.org; Tue, 20 Sep 2016 08:16:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bmJyF-0007no-KL for qemu-devel@nongnu.org; Tue, 20 Sep 2016 08:16:25 -0400 Date: Tue, 20 Sep 2016 14:16:07 +0200 From: Kevin Wolf Message-ID: <20160920121607.GD5807@noname.redhat.com> References: <1474303471-12509-1-git-send-email-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="NDin8bjvE/0mNLFQ" Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v4 0/2] block: allow flush on devices with open tray List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: John Snow , qemu-block@nongnu.org, qemu-devel@nongnu.org, qemu-stable@nongnu.org --NDin8bjvE/0mNLFQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Am 19.09.2016 um 22:58 hat Max Reitz geschrieben: > On 19.09.2016 18:44, John Snow wrote: > > Final re-send for wording. > >=20 > > The move to blk_flush altered the behavior of migration and flushing > > nodes that are not reachable via the guest, but are still reachable > > via QEMU and may or may not need to be flushed. > >=20 > > This is likely the simplest solution for now until we nail down our > > policy a bit more. > >=20 > > This is intended for 2.6.2 and/or 2.7.1, to fix problems with libvirt > > et al being unable to migrate QEMU when the CDROM tray is open. > >=20 > > v4: > > Commit message update. > >=20 > > v3: > > Trying to take a hint from Kevin, reinstating bdrv_flush_all. > > If it's not what we want, we can try moving back to v2, > > acknowledging that a nicer solution in the future: > > (A) Can skip flushing on devices that just don't need it, and > > (B) Optionally institutes some sort of flush-on-eject policy. > >=20 > > _______________________________________________________________________= _________ > >=20 > > For convenience, this branch is available at: > > https://github.com/jnsnow/qemu.git branch atapi-tray-migfix > > https://github.com/jnsnow/qemu/tree/atapi-tray-migfix > >=20 > > This version is tagged atapi-tray-migfix-v4: > > https://github.com/jnsnow/qemu/releases/tag/atapi-tray-migfix-v4 > >=20 > > John Snow (2): > > block: reintroduce bdrv_flush_all > > qemu: use bdrv_flush_all for vm_stop et al > >=20 > > block/io.c | 25 +++++++++++++++++++++++++ > > cpus.c | 4 ++-- > > include/block/block.h | 1 + > > 3 files changed, 28 insertions(+), 2 deletions(-) >=20 > Reviewed-by: Max Reitz Begs the question: Who is supposed to merge this? Stefan/Fam, who are formally responsible for block/io.c? Or one of us because it's more about managing block devices? Kevin --NDin8bjvE/0mNLFQ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJX4SiHAAoJEH8JsnLIjy/WJsIP/1xe1ZIq82/X/KQJUdS3JiLH yeXmgxZoKcPVGZvzn5ui/xb0SIGNnRDHfSp/Mg+kcuFrQNSzPdeV+e0ezX0QNWGi wWfjj67n3hNio7sWfHm6+PyRFqiw606jDO+END5PI5jVpVIyKign4jF7n3zl8cfM iFLoDU08+LuN21C4TOsnF3a7NGXONWrmuw5aoO8OBexSqeVB+wIlGhu6fgXWPlf6 kMHSDHboMnQeqpj7UoxJjEof5TgA5g0MdmJB8sJtkSXRj76GgYnb3YO13BCOH1V9 Wym4atsU9KC98SIqkkvEo0/ISlxHqMZEzr4yJX8a+i1AYBrEW6e5KGXb6IPH/47D baOvuL0Lv4kftAD9OKYOBtNTIxs4inV/DXN6ljiuI8uhkTpP26adwNoHzkB1HoY7 k5R+2vaHdIqAD1bHub7iwOM6j284aL1YaLMEWzmLvUgAJCaifeSH+pq0eP2eUOGN 2d8TrsSuRK4Bz0DCOzQ07aDFT0zWMuIimbLm1MlCDZ9ifLTUjZSGrkqEEQf64zaZ CpvKRYVGD9hON+2jgPdtOLmeedLXc4bOH9hKIGz22Qli6uCpz5egQ+1uxhgiE/st ggTyfUXUY+37FEkzealvn8geeDVUtkASeQ50EnCqXmgsKaP1/5m3MGmyMYDHzuKn QAVJx6WGjeKvxlPrplG7 =J0Mx -----END PGP SIGNATURE----- --NDin8bjvE/0mNLFQ--