Re: [Qemu-devel] [PATCH v3 0/8] replay additions

[no-reply@patchew.org]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Message-id: 20160920123126.5400.29283.stgit@PASHA-ISP.def.inno
Subject: [Qemu-devel] [PATCH v3 0/8] replay additions
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
1e5f827 integratorcp: adding vmstate for save/restore
ce7f8d8 replay: allow replay stopping and restarting
71b30fd replay: vmstate for replay module
a4dceb0 replay: move internal data to the structure
4a54806 replay: save/load initial state
3a8d660 block: don't make snapshots for filters
9c93c5a block: set snapshot option for block devices in blkreplay module
b84caf1 record/replay: add network support

=== OUTPUT BEGIN ===
Checking PATCH 1/8: record/replay: add network support...
WARNING: line over 80 characters
#122: FILE: net/filter-replay.c:35:
+static ssize_t filter_replay_receive_iov(NetFilterState *nf, NetClientState *sndr,

WARNING: line over 80 characters
#123: FILE: net/filter-replay.c:36:
+                                         unsigned flags, const struct iovec *iov,

WARNING: line over 80 characters
#296: FILE: replay/replay-net.c:42:
+                                network_filters_count * sizeof(*network_filters));

total: 0 errors, 3 warnings, 313 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 2/8: block: set snapshot option for block devices in blkreplay module...
Checking PATCH 3/8: block: don't make snapshots for filters...
Checking PATCH 4/8: replay: save/load initial state...
ERROR: g_free(NULL) is safe this check is probably not required
#169: FILE: replay/replay.c:350:
+    if (replay_snapshot) {
+        g_free(replay_snapshot);

total: 1 errors, 0 warnings, 141 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 5/8: replay: move internal data to the structure...
WARNING: line over 80 characters
#62: FILE: replay/replay-internal.c:158:
+                error_report("Replay: unknown event kind %d", replay_state.data_kind);

total: 0 errors, 1 warnings, 133 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 6/8: replay: vmstate for replay module...
Checking PATCH 7/8: replay: allow replay stopping and restarting...
Checking PATCH 8/8: integratorcp: adding vmstate for save/restore...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org