From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60549) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmJUx-0000yp-Pw for qemu-devel@nongnu.org; Tue, 20 Sep 2016 07:46:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bmJUs-0006Tt-Ks for qemu-devel@nongnu.org; Tue, 20 Sep 2016 07:46:02 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:46465) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmJUs-0006TV-Bi for qemu-devel@nongnu.org; Tue, 20 Sep 2016 07:45:58 -0400 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u8KBguSB059722 for ; Tue, 20 Sep 2016 07:45:57 -0400 Received: from e06smtp08.uk.ibm.com (e06smtp08.uk.ibm.com [195.75.94.104]) by mx0a-001b2d01.pphosted.com with ESMTP id 25k319wn3x-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 20 Sep 2016 07:45:57 -0400 Received: from localhost by e06smtp08.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 20 Sep 2016 12:45:55 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id DBCA917D8062 for ; Tue, 20 Sep 2016 12:47:51 +0100 (BST) Received: from d06av03.portsmouth.uk.ibm.com (d06av03.portsmouth.uk.ibm.com [9.149.37.213]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u8KBjrTF13959508 for ; Tue, 20 Sep 2016 11:45:53 GMT Received: from d06av03.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av03.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u8KBjqe9002911 for ; Tue, 20 Sep 2016 05:45:53 -0600 Date: Tue, 20 Sep 2016 13:45:50 +0200 From: Cornelia Huck In-Reply-To: <1460467534-29147-8-git-send-email-stefanha@redhat.com> References: <1460467534-29147-1-git-send-email-stefanha@redhat.com> <1460467534-29147-8-git-send-email-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-Id: <20160920134550.64a951d5.cornelia.huck@de.ibm.com> Subject: Re: [Qemu-devel] [PATCH v3 07/10] virtio: use unsigned int for virtqueue_get_avail_bytes() index List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" , Fam Zheng On Tue, 12 Apr 2016 14:25:31 +0100 Stefan Hajnoczi wrote: > The virtio code uses int, unsigned int, and uint16_t for virtqueue > indices. The uint16_t is used for the low-level descriptor layout in > virtio_ring.h while code that isn't concerned with descriptor layout can > use unsigned int. > > Use of int is problematic because it can result in signed/unsigned > comparison and incompatible int*/unsigned int* pointer types. > > Make the virtqueue_get_avail_bytes() 'i' variable unsigned int. This > eliminates the need to introduce casts and modify code further in the > patches that follow. > > Signed-off-by: Stefan Hajnoczi > --- > hw/virtio/virtio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Cornelia Huck