Re: [xiaolong.ye@intel.com: [mm] 0331ab667f: kernel BUG at mm/mmap.c:327!]

[Andrea Arcangeli <aarcange@redhat.com>]

On Tue, Sep 20, 2016 at 03:46:38PM +0200, Andrea Arcangeli wrote:
>  
> -	vma_rb_erase(vma, &mm->mm_rb);
> +	if (has_prev)
> +		vma_rb_erase_ignore(vma, &mm->mm_rb, ignore);
> +	else
> +		vma_rb_erase_ignore(vma, &mm->mm_rb, ignore);
>  	next = vma->vm_next;
>  	if (has_prev)

Once this is confirmed as false positive, the above can get a noop
cleanup before merging or I can do a more proper submit with this bit
cleaned up:

diff --git a/mm/mmap.c b/mm/mmap.c
index c682dee..0c5f6f7 100644
--- a/mm/mmap.c
+++ b/mm/mmap.c
@@ -627,10 +627,7 @@ static __always_inline void __vma_unlink_common(struct mm_struct *mm,
 {
 	struct vm_area_struct *next;
 
-	if (has_prev)
-		vma_rb_erase_ignore(vma, &mm->mm_rb, ignore);
-	else
-		vma_rb_erase_ignore(vma, &mm->mm_rb, ignore);
+	vma_rb_erase_ignore(vma, &mm->mm_rb, ignore);
 	next = vma->vm_next;
 	if (has_prev)
 		prev->vm_next = next;

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>