From: Stephen Boyd <sboyd@codeaurora.org>
To: Vladimir Zapolskiy <vz@mleia.com>
Cc: Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <kernel@pengutronix.de>,
Michael Turquette <mturquette@baylibre.com>,
Fabio Estevam <fabio.estevam@nxp.com>,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH 2/2] clk: imx31: properly init clocks for machines with DT
Date: Tue, 20 Sep 2016 10:36:46 -0700 [thread overview]
Message-ID: <20160920173646.GC8319@codeaurora.org> (raw)
In-Reply-To: <1474252939-12579-3-git-send-email-vz@mleia.com>
On 09/19, Vladimir Zapolskiy wrote:
> @@ -222,22 +215,31 @@ int __init mx31_clocks_init(unsigned long fref)
> return 0;
> }
>
> -int __init mx31_clocks_init_dt(void)
> +static void __init mx31_clocks_init_dt(struct device_node *np)
Alternatively we can leave mx31_clocks_init_dt() around as an
exported API, but make it return 0 immediately in the same patch
to the clk driver here. Then after rc1 we can delete the "unused"
function in the clk tree assuming the last caller has been
deleted through arm-soc.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] clk: imx31: properly init clocks for machines with DT
Date: Tue, 20 Sep 2016 10:36:46 -0700 [thread overview]
Message-ID: <20160920173646.GC8319@codeaurora.org> (raw)
In-Reply-To: <1474252939-12579-3-git-send-email-vz@mleia.com>
On 09/19, Vladimir Zapolskiy wrote:
> @@ -222,22 +215,31 @@ int __init mx31_clocks_init(unsigned long fref)
> return 0;
> }
>
> -int __init mx31_clocks_init_dt(void)
> +static void __init mx31_clocks_init_dt(struct device_node *np)
Alternatively we can leave mx31_clocks_init_dt() around as an
exported API, but make it return 0 immediately in the same patch
to the clk driver here. Then after rc1 we can delete the "unused"
function in the clk tree assuming the last caller has been
deleted through arm-soc.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-09-20 17:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 2:42 [PATCH 0/2] ARM: imx31/of: clk: init clock controller with CLK_OF_DECLARE Vladimir Zapolskiy
2016-09-19 2:42 ` Vladimir Zapolskiy
2016-09-19 2:42 ` [PATCH 1/2] ARM: imx31: remove mx31_clocks_init_dt() function calls Vladimir Zapolskiy
2016-09-19 2:42 ` Vladimir Zapolskiy
2016-09-19 2:42 ` [PATCH 2/2] clk: imx31: properly init clocks for machines with DT Vladimir Zapolskiy
2016-09-19 2:42 ` Vladimir Zapolskiy
2016-09-20 17:36 ` Stephen Boyd [this message]
2016-09-20 17:36 ` Stephen Boyd
2016-09-19 5:58 ` [PATCH 0/2] ARM: imx31/of: clk: init clock controller with CLK_OF_DECLARE Uwe Kleine-König
2016-09-19 5:58 ` Uwe Kleine-König
2016-09-20 17:32 ` Stephen Boyd
2016-09-20 17:32 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160920173646.GC8319@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=shawnguo@kernel.org \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.