From: Thomas Graf <tgraf@suug.ch>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Tom Herbert <tom@herbertland.com>,
davem@davemloft.net, netdev@vger.kernel.org,
roopa@cumulusnetworks.com, kernel-team@fb.com
Subject: Re: [PATCH net-next 5/7] rhashtable: abstract out function to get hash
Date: Tue, 20 Sep 2016 19:58:03 +0200 [thread overview]
Message-ID: <20160920175803.GE3291@pox.localdomain> (raw)
In-Reply-To: <20160920093659.GA20975@gondor.apana.org.au>
On 09/20/16 at 05:36pm, Herbert Xu wrote:
> Tom Herbert <tom@herbertland.com> wrote:
> > Split out most of rht_key_hashfn which is calculating the hash into
> > its own function. This way the hash function can be called separately to
> > get the hash value.
> >
> > Acked-by: Thomas Graf <tgraf@suug.ch>
> > Signed-off-by: Tom Herbert <tom@herbertland.com>
>
> I don't get this one. You're just using jhash, right? Why not
> call jhash directly instead of rht_get_key_hashfn?
FYI, there is a v2 of this series, just so you don't have to do the
work twice.
I understand this particular patch as an effort not to duplicate
hash function selection such as jhash vs jhash2 based on key_len.
next prev parent reply other threads:[~2016-09-20 17:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 23:22 [PATCH net-next 0/7] net: ILA resolver and generic resolver backend Tom Herbert
2016-09-14 23:22 ` [PATCH net-next 1/7] lwt: Add net to build_state argument Tom Herbert
2016-09-14 23:56 ` kbuild test robot
2016-09-15 0:17 ` kbuild test robot
2016-09-15 0:42 ` kbuild test robot
2016-09-15 17:17 ` Roopa Prabhu
2016-09-14 23:22 ` [PATCH net-next 2/7] spinlock: Add library function to allocate spinlock buckets array Tom Herbert
2016-09-14 23:22 ` [PATCH net-next 3/7] rhashtable: Call library function alloc_bucket_locks Tom Herbert
2016-09-20 9:29 ` Herbert Xu
2016-09-14 23:22 ` [PATCH net-next 4/7] ila: " Tom Herbert
2016-09-14 23:22 ` [PATCH net-next 5/7] rhashtable: abstract out function to get hash Tom Herbert
2016-09-20 9:36 ` Herbert Xu
2016-09-20 17:58 ` Thomas Graf [this message]
2016-09-21 2:46 ` Herbert Xu
2016-09-21 3:17 ` Tom Herbert
2016-09-14 23:22 ` [PATCH net-next 6/7] net: Generic resolver backend Tom Herbert
2016-09-20 9:40 ` Herbert Xu
2016-09-14 23:22 ` [PATCH net-next 7/7] ila: Resolver mechanism Tom Herbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160920175803.GE3291@pox.localdomain \
--to=tgraf@suug.ch \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.