From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50205) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmb3y-0000dg-Qk for qemu-devel@nongnu.org; Wed, 21 Sep 2016 02:31:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bmb3w-000233-9a for qemu-devel@nongnu.org; Wed, 21 Sep 2016 02:31:21 -0400 Date: Wed, 21 Sep 2016 15:56:41 +1000 From: David Gibson Message-ID: <20160921055641.GA10197@umbus.fritz.box> References: <1473943560-14846-1-git-send-email-clg@kaod.org> <1473943560-14846-8-git-send-email-clg@kaod.org> <1473977505.8689.371.camel@kernel.crashing.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="C7zPtVaVf+AK4Oqc" Content-Disposition: inline In-Reply-To: <1473977505.8689.371.camel@kernel.crashing.org> Subject: Re: [Qemu-devel] [PATCH v3 07/10] ppc/pnv: add XSCOM infrastructure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Benjamin Herrenschmidt Cc: =?iso-8859-1?Q?C=E9dric?= Le Goater , qemu-ppc@nongnu.org, qemu-devel@nongnu.org --C7zPtVaVf+AK4Oqc Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 16, 2016 at 08:11:45AM +1000, Benjamin Herrenschmidt wrote: > On Thu, 2016-09-15 at 14:45 +0200, C=E9dric Le Goater wrote: > > =A0- The PCB translation is too much of a constraint for a specific > > =A0=A0 XSCOM address space, unless someone can explain me how to addres= s 8 > > =A0=A0 bytes at 0xb0021 and another 8 different bytes at 0xb0022. I don= 't > > =A0=A0 think the address space and the memory regions were designed with > > =A0=A0 this in mind. Please advise ! >=20 > I'd say just dispatch pcb_addr << 3 to the memory regions (which is > also the P9 translation iirc). Yes, I think that's the way to go. That also means on P9 you can potentially just map the scom address space directly into address_space_memory, instead of requiring a redispatcher to do the address mangling. > Just add a quirk to the ADU/XSCOM dispatch object to do the additional > unmangling needed on P7/P8 >=20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --C7zPtVaVf+AK4Oqc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJX4iEXAAoJEGw4ysog2bOSvGQQALUGXShk6OYNh18qdmXKUfqZ 9ScvknqiW6r5FbF2/zkGbDo9cRUYdcY6Y6sbNP7CAp6HlNBHA5jpHZzASHDQDn5/ XmEVN10XqtO4u9xZNTPStLchNi9HRLp6nkmeFLURtuO0Pfv8LdrS6HOtFRZQYcyy SZgwHMu8/JU5mlNRpjEZ6P5SPVUMtcOyin48SpL3YEVxdEIRq6cdhGU9CZMYPWbY jaIH5+qiIp3l+MXjGCesf7xnO+q1fmEEB00W/8Tus8ErNNitPSfRncm/0h+WM1gw ozTJ9PcLnIdbnLKk4TArMkFI5GkbzM+qu9SxUdRghpER88Kd2g50mlul9FEki2Nh TNLM+e98eDK9KUKixiU+RuWoFOasNlUb3LouZ6kn/STD3Wm8DKh7OvNtn6M0R/zn HHpGF6oqSRBTZb9IVQJ9UlBMFJ6kdi0w19VCnopJoud/MvvX3P0C7JFziDRYT6Dn VFI9f8FNUBQF7EYal+5bp+kD19hLDXyQ16q5PcBnnHA8JscvgQcvkJ5rcra7D6Np /y7ztiGXy6HHGcfGNvSWrBIJ7f+BL58K9++OlYTWj4hUt7yiDQsgYp3G7lmaN79X 7cOITl0hxKiFd532NcSZGO1JY89Lj0lse0OmRvYuMMcl6vw3ePKo/tdRPkx8Bgo/ lG+eBCnBC+JeVSF4L39m =b88P -----END PGP SIGNATURE----- --C7zPtVaVf+AK4Oqc--