From: David Gibson <david@gibson.dropbear.id.au>
To: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
benh@kernel.crashing.org, clg@kaod.org
Subject: Re: [Qemu-devel] [PATCH v4 4/9] ppc/xics: An ICS with offset 0 is assumed to be uninitialized
Date: Wed, 21 Sep 2016 17:50:22 +1000 [thread overview]
Message-ID: <20160921075022.GC1809@umbus.fritz.box> (raw)
In-Reply-To: <1474266577-11704-5-git-send-email-nikunj@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 1211 bytes --]
On Mon, Sep 19, 2016 at 11:59:32AM +0530, Nikunj A Dadhania wrote:
> From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>
> This will make life easier for dealing with dynamically configured
> ICSes such as PHB3
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> Signed-off-by: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
This seems reasonable on its own, so I've applied it to ppc-for-2.8.
> ---
> include/hw/ppc/xics.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/hw/ppc/xics.h b/include/hw/ppc/xics.h
> index 1ea40bd..e49a2da 100644
> --- a/include/hw/ppc/xics.h
> +++ b/include/hw/ppc/xics.h
> @@ -151,7 +151,7 @@ struct ICSState {
>
> static inline bool ics_valid_irq(ICSState *ics, uint32_t nr)
> {
> - return (nr >= ics->offset)
> + return (ics->offset != 0) && (nr >= ics->offset)
> && (nr < (ics->offset + ics->nr_irqs));
> }
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-09-21 9:28 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 6:29 [Qemu-devel] [PATCH v4 0/9] sPAPR xics rework/cleanup Nikunj A Dadhania
2016-09-19 6:29 ` [Qemu-devel] [PATCH v4 1/9] ppc/xics: account correct irq status Nikunj A Dadhania
2016-09-21 6:39 ` David Gibson
2016-09-19 6:29 ` [Qemu-devel] [PATCH v4 2/9] ppc/xics: Fix migration failure with kernel-irqchip=off Nikunj A Dadhania
2016-09-21 7:21 ` David Gibson
2016-09-19 6:29 ` [Qemu-devel] [PATCH v4 3/9] ppc/xics: Make the ICSState a list Nikunj A Dadhania
2016-09-19 6:59 ` [Qemu-devel] [Qemu-ppc] " Cédric Le Goater
2016-09-19 7:02 ` Nikunj A Dadhania
2016-09-19 7:24 ` Cédric Le Goater
2016-09-20 5:13 ` Nikunj A Dadhania
2016-09-21 7:48 ` [Qemu-devel] " David Gibson
2016-09-19 6:29 ` [Qemu-devel] [PATCH v4 4/9] ppc/xics: An ICS with offset 0 is assumed to be uninitialized Nikunj A Dadhania
2016-09-21 7:50 ` David Gibson [this message]
2016-09-19 6:29 ` [Qemu-devel] [PATCH v4 5/9] ppc/xics: Use a helper to add a new ICS Nikunj A Dadhania
2016-09-21 23:40 ` David Gibson
2016-09-22 6:21 ` Cédric Le Goater
2016-09-23 0:37 ` David Gibson
2016-09-19 6:29 ` [Qemu-devel] [PATCH v4 6/9] ppc/xics: Split ICS into ics-base and ics class Nikunj A Dadhania
2016-09-19 7:09 ` [Qemu-devel] [Qemu-ppc] " Cédric Le Goater
2016-09-20 5:14 ` Nikunj A Dadhania
2016-09-19 14:34 ` Cédric Le Goater
2016-09-20 6:02 ` Nikunj A Dadhania
2016-09-20 6:20 ` Cédric Le Goater
2016-09-20 6:29 ` Nikunj A Dadhania
2016-09-20 7:13 ` Cédric Le Goater
2016-09-20 8:10 ` Nikunj A Dadhania
2016-09-20 9:06 ` Cédric Le Goater
2016-09-20 9:41 ` Nikunj A Dadhania
2016-09-20 9:52 ` Cédric Le Goater
2016-09-20 10:03 ` Nikunj A Dadhania
2016-09-19 6:29 ` [Qemu-devel] [PATCH v4 7/9] ppc/xics: Add "native" XICS subclass Nikunj A Dadhania
2016-09-19 7:03 ` [Qemu-devel] [Qemu-ppc] " Cédric Le Goater
2016-09-22 0:02 ` [Qemu-devel] " David Gibson
2016-09-22 6:27 ` Cédric Le Goater
2016-09-19 6:29 ` [Qemu-devel] [PATCH v4 8/9] ppc/xics: Add xics to the monitor "info pic" command Nikunj A Dadhania
2016-09-22 0:07 ` David Gibson
2016-09-19 6:29 ` [Qemu-devel] [PATCH v4 9/9] ppc/xics: move set_nr_{irqs, servers} to xics.c Nikunj A Dadhania
2016-09-22 0:14 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160921075022.GC1809@umbus.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=benh@kernel.crashing.org \
--cc=clg@kaod.org \
--cc=nikunj@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.