From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54942)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1bmd27-0001Gi-Ax
	for qemu-devel@nongnu.org; Wed, 21 Sep 2016 04:37:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1bmd23-0002HU-2m
	for qemu-devel@nongnu.org; Wed, 21 Sep 2016 04:37:34 -0400
Received: from mx1.redhat.com ([209.132.183.28]:55494)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1bmd22-0002HI-Rv
	for qemu-devel@nongnu.org; Wed, 21 Sep 2016 04:37:30 -0400
Date: Wed, 21 Sep 2016 09:37:26 +0100
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20160921083726.GB15535@redhat.com>
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
References: <1474429768-25027-1-git-send-email-famz@redhat.com>
	<1474429768-25027-2-git-send-email-famz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1474429768-25027-2-git-send-email-famz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/9] docker: Generate /packages.txt in
 centos6 image
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>

On Wed, Sep 21, 2016 at 11:49:20AM +0800, Fam Zheng wrote:
> Put the list of package names in an environment, and output their
> package names to the target file in the end.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  tests/docker/dockerfiles/centos6.docker | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/docker/dockerfiles/centos6.docker b/tests/docker/dockerfiles/centos6.docker
> index 8f4fe46..34e0d3b 100644
> --- a/tests/docker/dockerfiles/centos6.docker
> +++ b/tests/docker/dockerfiles/centos6.docker
> @@ -1,6 +1,8 @@
>  FROM centos:6
> -RUN yum install -y \
> +RUN yum install -y epel-release
> +ENV PACKAGES libfdt-devel ccache \
>      tar git make gcc g++ \
>      zlib-devel glib2-devel SDL-devel pixman-devel \
>      epel-release
> -RUN yum install -y libfdt-devel ccache
> +RUN yum install -y $PACKAGES
> +RUN rpm -q $PACKAGES | sort > /packages.txt

Reviewed-by: Daniel P. Berrange <berrange@redhat.com>

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|