Re: [Qemu-devel] [PATCH 9/9] docker: exec $CMD

["Daniel P. Berrange" <berrange@redhat.com>]

On Wed, Sep 21, 2016 at 11:49:28AM +0800, Fam Zheng wrote:
> This is the last command to run (unless DEBUG), make it 'exec' to
> simplify the process tree.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  tests/docker/run | 15 +++++++++------
>  1 file changed, 9 insertions(+), 6 deletions(-)
> 
> diff --git a/tests/docker/run b/tests/docker/run
> index ed7dd31..c1e4513 100755
> --- a/tests/docker/run
> +++ b/tests/docker/run
> @@ -57,14 +57,17 @@ cd "$QEMU_SRC/tests/docker"
>  
>  CMD="$QEMU_SRC/tests/docker/$@"
>  
> -if test -n "$DEBUG"; then
> -    echo "* Prepared to run command:"
> -    echo "  $CMD"
> -    echo "* Hit Ctrl-D to continue, or type 'exit 1' to abort"
> -    echo
> -    $SHELL
> +if test -z "$DEBUG"; then
> +    exec $CMD
>  fi
>  
> +# DEBUG workflow
> +echo "* Prepared to run command:"
> +echo "  $CMD"
> +echo "* Hit Ctrl-D to continue, or type 'exit 1' to abort"
> +echo
> +$SHELL
> +
>  if "$CMD"; then
>      exit 0
>  elif test -n "$DEBUG"; then

Reviewed-by: Daniel P. Berrange <berrange@redhat.com>

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|