From: Greg KH <gregkh@linuxfoundation.org>
To: Valentin Rothberg <valentinrothberg@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: staging/greybus: undefined Kconfig symbols
Date: Wed, 21 Sep 2016 12:34:40 +0200 [thread overview]
Message-ID: <20160921103440.GA7244@kroah.com> (raw)
In-Reply-To: <CAD3Xx4LG7DyUeYZqzT3B-ZwcFafeWnt6718G_gjG7n67zCPDig@mail.gmail.com>
On Wed, Sep 21, 2016 at 12:25:54PM +0200, Valentin Rothberg wrote:
> On Wed, Sep 21, 2016 at 9:39 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Wed, Sep 21, 2016 at 08:30:01AM +0200, Valentin Rothberg wrote:
> >> Hi Greg,
> >
> > <fixing odd email address you used for me...>
>
> I was a little surprised, too, but that's the one in the signed-off
> field in the greybus commits, so I used it.
Not a problem, but the MAINTAINERS file should have the correct one to
use for this subsystem (it's not just me maintaining it...)
> >> checkkconfigsymbols.py found some undefined Kconfig symbols (see
> >> below) in the Makefile and Kconfig file. I could not find any patch
> >> adding those symbols. Are there patches queued somewhere else?
> >>
> >> Best regards,
> >> Valentin
> >>
> >> GREYBUS_AUDIO_MSM8994
> >> Referencing files: drivers/staging/greybus/Makefile
> >> Similar symbols: GREYBUS_AUDIO, GREYBUS_GPIO, GREYBUS_SDIO, GREYBUS_USB
> >> Commits changing symbol:
> >> - d4f56b47a8fa ("staging: greybus: Add drivers/staging/greybus to the build")
> >
> > This one is tricky, as parts of this audio driver depended on an
> > out-of-tree qualcomm audio driver. It will be unwound over time to not
> > depend on that mess.
> >
> >> MEDIA
> >> Referencing files: drivers/staging/greybus/Kconfig
> >> Similar symbols: COMEDI, EDAC, EISA, HID_CMEDIA, LANMEDIA, MDIO,
> >> MEDIA_CEC, MEDIA_TUNER, MEMDMA0, MEMDMA1
> >> Commits changing symbol:
> >> - d4f56b47a8fa ("staging: greybus: Add drivers/staging/greybus to the build")
> >> - 847175e8e660 ("greybus: audio: Fetch jack_mask, button_mask from
> >> module's topology data")
> >> - 64a7e2cceb75 ("greybus: audio: Added jack support to audio module")
> >
> > Ugh, this should be CONFIG_MEDIA_SUPPORT, right? If so, I'll make a
> > patch to change this, that was my fault.
>
> Yes, since it's a camera driver, MEDIA_SUPPORT seems to be the good dependency.
Great, I'll make up a patch for this, thanks.
greg k-h
prev parent reply other threads:[~2016-09-21 10:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-21 6:30 staging/greybus: undefined Kconfig symbols Valentin Rothberg
2016-09-21 7:39 ` Greg KH
2016-09-21 10:25 ` Valentin Rothberg
2016-09-21 10:34 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160921103440.GA7244@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=valentinrothberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.