From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ross Zwisler Subject: Re: [PATCH v2 1/9] ext4: allow DAX writeback for hole punch Date: Wed, 21 Sep 2016 09:22:44 -0600 Message-ID: <20160921152244.GB10516@linux.intel.com> References: <20160823220419.11717-1-ross.zwisler@linux.intel.com> <20160823220419.11717-2-ross.zwisler@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-kernel@vger.kernel.org, Theodore Ts'o , Alexander Viro , Andreas Dilger , Andrew Morton , Dan Williams , Dave Chinner , Jan Kara , linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-nvdimm@lists.01.org, Matthew Wilcox , stable@vger.kernel.org To: Theodore Ts'o , Jan Kara Return-path: Content-Disposition: inline In-Reply-To: <20160823220419.11717-2-ross.zwisler@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-ext4.vger.kernel.org On Tue, Aug 23, 2016 at 04:04:11PM -0600, Ross Zwisler wrote: > Currently when doing a DAX hole punch with ext4 we fail to do a writeback. > This is because the logic around filemap_write_and_wait_range() in > ext4_punch_hole() only looks for dirty page cache pages in the radix tree, > not for dirty DAX exceptional entries. > > Signed-off-by: Ross Zwisler > Reviewed-by: Jan Kara > Cc: Ted & Jan, I'm still working on the latest version of the PMD work which integrates with the new struct iomap faults. At this point it doesn't look like I'm going to make v4.9, but I think that this bug fix at least should probably go in alone? Thanks, - Ross > --- > fs/ext4/inode.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c > index 3131747..0900cb4 100644 > --- a/fs/ext4/inode.c > +++ b/fs/ext4/inode.c > @@ -3890,7 +3890,7 @@ int ext4_update_disksize_before_punch(struct inode *inode, loff_t offset, > } > > /* > - * ext4_punch_hole: punches a hole in a file by releaseing the blocks > + * ext4_punch_hole: punches a hole in a file by releasing the blocks > * associated with the given offset and length > * > * @inode: File inode > @@ -3919,7 +3919,7 @@ int ext4_punch_hole(struct inode *inode, loff_t offset, loff_t length) > * Write out all dirty pages to avoid race conditions > * Then release them. > */ > - if (mapping->nrpages && mapping_tagged(mapping, PAGECACHE_TAG_DIRTY)) { > + if (mapping_tagged(mapping, PAGECACHE_TAG_DIRTY)) { > ret = filemap_write_and_wait_range(mapping, offset, > offset + length - 1); > if (ret) > -- > 2.9.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7EE681A1EEF for ; Wed, 21 Sep 2016 08:22:46 -0700 (PDT) Date: Wed, 21 Sep 2016 09:22:44 -0600 From: Ross Zwisler Subject: Re: [PATCH v2 1/9] ext4: allow DAX writeback for hole punch Message-ID: <20160921152244.GB10516@linux.intel.com> References: <20160823220419.11717-1-ross.zwisler@linux.intel.com> <20160823220419.11717-2-ross.zwisler@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20160823220419.11717-2-ross.zwisler@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Theodore Ts'o , Jan Kara Cc: linux-nvdimm@lists.01.org, Matthew Wilcox , Dave Chinner , linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux-mm@kvack.org, Andreas Dilger , Alexander Viro , Jan Kara , linux-fsdevel@vger.kernel.org, Andrew Morton , linux-ext4@vger.kernel.org List-ID: On Tue, Aug 23, 2016 at 04:04:11PM -0600, Ross Zwisler wrote: > Currently when doing a DAX hole punch with ext4 we fail to do a writeback. > This is because the logic around filemap_write_and_wait_range() in > ext4_punch_hole() only looks for dirty page cache pages in the radix tree, > not for dirty DAX exceptional entries. > > Signed-off-by: Ross Zwisler > Reviewed-by: Jan Kara > Cc: Ted & Jan, I'm still working on the latest version of the PMD work which integrates with the new struct iomap faults. At this point it doesn't look like I'm going to make v4.9, but I think that this bug fix at least should probably go in alone? Thanks, - Ross > --- > fs/ext4/inode.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c > index 3131747..0900cb4 100644 > --- a/fs/ext4/inode.c > +++ b/fs/ext4/inode.c > @@ -3890,7 +3890,7 @@ int ext4_update_disksize_before_punch(struct inode *inode, loff_t offset, > } > > /* > - * ext4_punch_hole: punches a hole in a file by releaseing the blocks > + * ext4_punch_hole: punches a hole in a file by releasing the blocks > * associated with the given offset and length > * > * @inode: File inode > @@ -3919,7 +3919,7 @@ int ext4_punch_hole(struct inode *inode, loff_t offset, loff_t length) > * Write out all dirty pages to avoid race conditions > * Then release them. > */ > - if (mapping->nrpages && mapping_tagged(mapping, PAGECACHE_TAG_DIRTY)) { > + if (mapping_tagged(mapping, PAGECACHE_TAG_DIRTY)) { > ret = filemap_write_and_wait_range(mapping, offset, > offset + length - 1); > if (ret) > -- > 2.9.0 > _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 21 Sep 2016 09:22:44 -0600 From: Ross Zwisler To: Theodore Ts'o , Jan Kara Cc: linux-kernel@vger.kernel.org, Theodore Ts'o , Alexander Viro , Andreas Dilger , Andrew Morton , Dan Williams , Dave Chinner , Jan Kara , linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-nvdimm@lists.01.org, Matthew Wilcox , stable@vger.kernel.org Subject: Re: [PATCH v2 1/9] ext4: allow DAX writeback for hole punch Message-ID: <20160921152244.GB10516@linux.intel.com> References: <20160823220419.11717-1-ross.zwisler@linux.intel.com> <20160823220419.11717-2-ross.zwisler@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160823220419.11717-2-ross.zwisler@linux.intel.com> Sender: owner-linux-mm@kvack.org List-ID: On Tue, Aug 23, 2016 at 04:04:11PM -0600, Ross Zwisler wrote: > Currently when doing a DAX hole punch with ext4 we fail to do a writeback. > This is because the logic around filemap_write_and_wait_range() in > ext4_punch_hole() only looks for dirty page cache pages in the radix tree, > not for dirty DAX exceptional entries. > > Signed-off-by: Ross Zwisler > Reviewed-by: Jan Kara > Cc: Ted & Jan, I'm still working on the latest version of the PMD work which integrates with the new struct iomap faults. At this point it doesn't look like I'm going to make v4.9, but I think that this bug fix at least should probably go in alone? Thanks, - Ross > --- > fs/ext4/inode.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c > index 3131747..0900cb4 100644 > --- a/fs/ext4/inode.c > +++ b/fs/ext4/inode.c > @@ -3890,7 +3890,7 @@ int ext4_update_disksize_before_punch(struct inode *inode, loff_t offset, > } > > /* > - * ext4_punch_hole: punches a hole in a file by releaseing the blocks > + * ext4_punch_hole: punches a hole in a file by releasing the blocks > * associated with the given offset and length > * > * @inode: File inode > @@ -3919,7 +3919,7 @@ int ext4_punch_hole(struct inode *inode, loff_t offset, loff_t length) > * Write out all dirty pages to avoid race conditions > * Then release them. > */ > - if (mapping->nrpages && mapping_tagged(mapping, PAGECACHE_TAG_DIRTY)) { > + if (mapping_tagged(mapping, PAGECACHE_TAG_DIRTY)) { > ret = filemap_write_and_wait_range(mapping, offset, > offset + length - 1); > if (ret) > -- > 2.9.0 > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f71.google.com (mail-pa0-f71.google.com [209.85.220.71]) by kanga.kvack.org (Postfix) with ESMTP id 4B4A928024E for ; Wed, 21 Sep 2016 11:22:47 -0400 (EDT) Received: by mail-pa0-f71.google.com with SMTP id fu14so99016253pad.0 for ; Wed, 21 Sep 2016 08:22:47 -0700 (PDT) Received: from mga02.intel.com (mga02.intel.com. [134.134.136.20]) by mx.google.com with ESMTPS id 3si41102372pad.284.2016.09.21.08.22.46 for (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 21 Sep 2016 08:22:46 -0700 (PDT) Date: Wed, 21 Sep 2016 09:22:44 -0600 From: Ross Zwisler Subject: Re: [PATCH v2 1/9] ext4: allow DAX writeback for hole punch Message-ID: <20160921152244.GB10516@linux.intel.com> References: <20160823220419.11717-1-ross.zwisler@linux.intel.com> <20160823220419.11717-2-ross.zwisler@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160823220419.11717-2-ross.zwisler@linux.intel.com> Sender: owner-linux-mm@kvack.org List-ID: To: Theodore Ts'o , Jan Kara Cc: linux-kernel@vger.kernel.org, Alexander Viro , Andreas Dilger , Andrew Morton , Dan Williams , Dave Chinner , Jan Kara , linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-nvdimm@lists.01.org, Matthew Wilcox , stable@vger.kernel.org On Tue, Aug 23, 2016 at 04:04:11PM -0600, Ross Zwisler wrote: > Currently when doing a DAX hole punch with ext4 we fail to do a writeback. > This is because the logic around filemap_write_and_wait_range() in > ext4_punch_hole() only looks for dirty page cache pages in the radix tree, > not for dirty DAX exceptional entries. > > Signed-off-by: Ross Zwisler > Reviewed-by: Jan Kara > Cc: Ted & Jan, I'm still working on the latest version of the PMD work which integrates with the new struct iomap faults. At this point it doesn't look like I'm going to make v4.9, but I think that this bug fix at least should probably go in alone? Thanks, - Ross > --- > fs/ext4/inode.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c > index 3131747..0900cb4 100644 > --- a/fs/ext4/inode.c > +++ b/fs/ext4/inode.c > @@ -3890,7 +3890,7 @@ int ext4_update_disksize_before_punch(struct inode *inode, loff_t offset, > } > > /* > - * ext4_punch_hole: punches a hole in a file by releaseing the blocks > + * ext4_punch_hole: punches a hole in a file by releasing the blocks > * associated with the given offset and length > * > * @inode: File inode > @@ -3919,7 +3919,7 @@ int ext4_punch_hole(struct inode *inode, loff_t offset, loff_t length) > * Write out all dirty pages to avoid race conditions > * Then release them. > */ > - if (mapping->nrpages && mapping_tagged(mapping, PAGECACHE_TAG_DIRTY)) { > + if (mapping_tagged(mapping, PAGECACHE_TAG_DIRTY)) { > ret = filemap_write_and_wait_range(mapping, offset, > offset + length - 1); > if (ret) > -- > 2.9.0 > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757613AbcIUPWt (ORCPT ); Wed, 21 Sep 2016 11:22:49 -0400 Received: from mga03.intel.com ([134.134.136.65]:27275 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757327AbcIUPWr (ORCPT ); Wed, 21 Sep 2016 11:22:47 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,374,1470726000"; d="scan'208";a="882326372" Date: Wed, 21 Sep 2016 09:22:44 -0600 From: Ross Zwisler To: "Theodore Ts'o" , Jan Kara Cc: linux-kernel@vger.kernel.org, "Theodore Ts'o" , Alexander Viro , Andreas Dilger , Andrew Morton , Dan Williams , Dave Chinner , Jan Kara , linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-nvdimm@ml01.01.org, Matthew Wilcox , stable@vger.kernel.org Subject: Re: [PATCH v2 1/9] ext4: allow DAX writeback for hole punch Message-ID: <20160921152244.GB10516@linux.intel.com> Mail-Followup-To: Ross Zwisler , Theodore Ts'o , Jan Kara , linux-kernel@vger.kernel.org, Alexander Viro , Andreas Dilger , Andrew Morton , Dan Williams , Dave Chinner , Jan Kara , linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-nvdimm@lists.01.org, Matthew Wilcox , stable@vger.kernel.org References: <20160823220419.11717-1-ross.zwisler@linux.intel.com> <20160823220419.11717-2-ross.zwisler@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160823220419.11717-2-ross.zwisler@linux.intel.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 23, 2016 at 04:04:11PM -0600, Ross Zwisler wrote: > Currently when doing a DAX hole punch with ext4 we fail to do a writeback. > This is because the logic around filemap_write_and_wait_range() in > ext4_punch_hole() only looks for dirty page cache pages in the radix tree, > not for dirty DAX exceptional entries. > > Signed-off-by: Ross Zwisler > Reviewed-by: Jan Kara > Cc: Ted & Jan, I'm still working on the latest version of the PMD work which integrates with the new struct iomap faults. At this point it doesn't look like I'm going to make v4.9, but I think that this bug fix at least should probably go in alone? Thanks, - Ross > --- > fs/ext4/inode.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c > index 3131747..0900cb4 100644 > --- a/fs/ext4/inode.c > +++ b/fs/ext4/inode.c > @@ -3890,7 +3890,7 @@ int ext4_update_disksize_before_punch(struct inode *inode, loff_t offset, > } > > /* > - * ext4_punch_hole: punches a hole in a file by releaseing the blocks > + * ext4_punch_hole: punches a hole in a file by releasing the blocks > * associated with the given offset and length > * > * @inode: File inode > @@ -3919,7 +3919,7 @@ int ext4_punch_hole(struct inode *inode, loff_t offset, loff_t length) > * Write out all dirty pages to avoid race conditions > * Then release them. > */ > - if (mapping->nrpages && mapping_tagged(mapping, PAGECACHE_TAG_DIRTY)) { > + if (mapping_tagged(mapping, PAGECACHE_TAG_DIRTY)) { > ret = filemap_write_and_wait_range(mapping, offset, > offset + length - 1); > if (ret) > -- > 2.9.0 >