Re: [PATCH] staging: android: ion: hisilicon: Use pointer to memory being allocated as the sizeof argument

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Wed, Sep 21, 2016 at 09:11:14PM +0530, sayli karnik wrote:
> This patch finds cases where the argument to sizeof is wrong in memory
> allocation functions by checking the type of the allocated memory when it is a
> double pointer and ensuring the sizeof argument takes a pointer to the memory
> being allocated.

Are you sure?


> Done using coccinelle:
> @@
> type T;
> T **x;
> @@
> 
>   x =
>   <+...sizeof(
> - T
> + *x
>   )...+>
> 
> Signed-off-by: sayli karnik <karniksayli1995@gmail.com>
> ---
>  drivers/staging/android/ion/hisilicon/hi6220_ion.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/android/ion/hisilicon/hi6220_ion.c b/drivers/staging/android/ion/hisilicon/hi6220_ion.c
> index 659aa71..9f9b244 100644
> --- a/drivers/staging/android/ion/hisilicon/hi6220_ion.c
> +++ b/drivers/staging/android/ion/hisilicon/hi6220_ion.c
> @@ -57,7 +57,7 @@ static int hi6220_ion_probe(struct platform_device *pdev)
>  		return PTR_ERR(ipdev->data);
>  
>  	ipdev->heaps = devm_kzalloc(&pdev->dev,
> -				sizeof(struct ion_heap)*ipdev->data->nr,
> +				sizeof(*ipdev->heaps) * ipdev->data->nr,

Do we really want to allocate an array of pointers, or an array of
structures?  Which is it, as it's not obvious...

thanks,

greg k-h