From: Greg KH <gregkh@linuxfoundation.org>
To: Georgiana Rodica Chelu <georgiana.chelu93@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [PATCH] staging: rtl8188eu: hal: rtl8188e_cmd: Use ether_addr_copy() instead of memcpy()
Date: Thu, 22 Sep 2016 09:14:16 +0200 [thread overview]
Message-ID: <20160922071416.GA22392@kroah.com> (raw)
In-Reply-To: <20160920125740.GA13784@fireworks>
On Tue, Sep 20, 2016 at 03:57:40PM +0300, Georgiana Rodica Chelu wrote:
> The checkpatch.pl found the warning:
> WARNING: Prefer ether_addr_copy() over memcpy() if the Ethernet
> addresses are __aligned(2)
>
> Checked if the the Ethernet addresses are __aligned(2) by using pahole
> tool. The type of pwlanhdr is struct ieee80211_hdr and pahole shows that
> addr1, addr2, and addr3 are aligned to u16.
>
> struct ieee80211_hdr {
> __le16 frame_control; /* 0 2
> */
Your changelog here is line-wrapped, can you fix it up please?
thanks,
greg k-h
next prev parent reply other threads:[~2016-09-22 7:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 12:57 [PATCH] staging: rtl8188eu: hal: rtl8188e_cmd: Use ether_addr_copy() instead of memcpy() Georgiana Rodica Chelu
2016-09-22 7:14 ` Greg KH [this message]
2016-09-23 6:16 ` Georgiana Chelu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160922071416.GA22392@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=georgiana.chelu93@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.