From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46589)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1bmz7J-0004K4-0K
	for qemu-devel@nongnu.org; Thu, 22 Sep 2016 04:12:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1bmz7E-0005Y5-9E
	for qemu-devel@nongnu.org; Thu, 22 Sep 2016 04:12:23 -0400
Received: from mx1.redhat.com ([209.132.183.28]:42390)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1bmz7E-0005Xn-2X
	for qemu-devel@nongnu.org; Thu, 22 Sep 2016 04:12:20 -0400
Date: Thu, 22 Sep 2016 09:12:16 +0100
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20160922081216.GE352@redhat.com>
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
References: <1474526149-318028-1-git-send-email-arei.gonglei@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1474526149-318028-1-git-send-email-arei.gonglei@huawei.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] qtest: fix make check complaint in crypto
 module
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gonglei <arei.gonglei@huawei.com>
Cc: qemu-devel@nongnu.org, wu.wubin@huawei.com

On Thu, Sep 22, 2016 at 02:35:49PM +0800, Gonglei wrote:
>   CC    tests/test-crypto-tlscredsx509.o
>   CC    tests/crypto-tls-x509-helpers.o
>   CC    tests/pkix_asn1_tab.o
> tests/pkix_asn1_tab.c:7:22: warning: libtasn1.h: No such file or direct=
ory
> tests/pkix_asn1_tab.c:9: error: expected =E2=80=98=3D=E2=80=99, =E2=80=98=
,=E2=80=99, =E2=80=98;=E2=80=99, =E2=80=98asm=E2=80=99 or =E2=80=98__attr=
ibute__=E2=80=99 before =E2=80=98pkix_asn1_tab=E2=80=99
> make: *** [tests/pkix_asn1_tab.o] Error 1
>=20
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
>  tests/Makefile.include | 4 ++++
>  1 file changed, 4 insertions(+)
>=20
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index e560ecb..ad6950f 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -92,8 +92,10 @@ gcov-files-test-write-threshold-y =3D block/write-th=
reshold.c
>  check-unit-y +=3D tests/test-crypto-hash$(EXESUF)
>  check-unit-y +=3D tests/test-crypto-cipher$(EXESUF)
>  check-unit-y +=3D tests/test-crypto-secret$(EXESUF)
> +ifeq ($(CONFIG_TASN1),y)
>  check-unit-$(CONFIG_GNUTLS) +=3D tests/test-crypto-tlscredsx509$(EXESU=
F)
>  check-unit-$(CONFIG_GNUTLS) +=3D tests/test-crypto-tlssession$(EXESUF)
> +endif

We already check this condition in tests/crypto-tls-x509-helpers.h  and
.c files should conditionalize themselves with

   #ifdef QCRYPTO_HAVE_TLS_TEST_SUPPORT

the tests/pkix_asn1_tab.c file is just missing that check

Regards,
Daniel
--=20
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange=
/ :|
|: http://libvirt.org              -o-             http://virt-manager.or=
g :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr=
/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vn=
c :|