From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47732) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmzBd-0008P4-EP for qemu-devel@nongnu.org; Thu, 22 Sep 2016 04:16:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bmzBZ-00071x-Oj for qemu-devel@nongnu.org; Thu, 22 Sep 2016 04:16:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36382) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmzBZ-00071U-J4 for qemu-devel@nongnu.org; Thu, 22 Sep 2016 04:16:49 -0400 Date: Thu, 22 Sep 2016 09:16:45 +0100 From: "Daniel P. Berrange" Message-ID: <20160922081645.GF352@redhat.com> Reply-To: "Daniel P. Berrange" References: <1474525997-318296-1-git-send-email-arei.gonglei@huawei.com> <20160922071646.381992.94741@ex-std-node742.prod.rhcloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160922071646.381992.94741@ex-std-node742.prod.rhcloud.com> Subject: Re: [Qemu-devel] [PATCH] crypto: add CTR mode support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: arei.gonglei@huawei.com, famz@redhat.com, wu.wubin@huawei.com On Thu, Sep 22, 2016 at 12:17:43AM -0700, no-reply@ec2-52-6-146-230.compute-1.amazonaws.com wrote: > Hi, > > Your series failed automatic build test. Please find the testing commands and > their output below. If you have docker installed, you can probably reproduce it > locally. > GTESTER tests/test-crypto-cipher > ** > ERROR:/tmp/qemu-test/src/tests/test-crypto-cipher.c:528:test_cipher: assertion failed: (err == NULL) > GTESTER tests/test-crypto-secret > GTESTER tests/test-qga > GTESTER tests/test-timed-average > GTESTER tests/test-io-task > GTester: last random seed: R02S94c4e01f686829a0cec78fda5b9551b8 > ** > ERROR:/tmp/qemu-test/src/tests/test-crypto-cipher.c:528:test_cipher: assertion failed: (err == NULL) > GTESTER tests/test-io-channel-socket > GTester: last random seed: R02S2749a35e038d902a633846f61116c95d > GTESTER tests/test-io-channel-file > ** > ERROR:/tmp/qemu-test/src/tests/test-crypto-cipher.c:528:test_cipher: assertion failed: (err == NULL) It seems you exposed a pre-existing bug in the test suite. It is using qcrypto_cipher_supports() to check if the cipher algorithm is supported before running each test case. Unfortunately this assumes that if the algorithm is supported, then all cipher modes are also supported, which is not true with --disable-gcrypt --disable-nettle configure flags. So we need to extend qcrypto_cipher_supports() to take both the algorithm and mode as parameters. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|