From: Jean Delvare <jdelvare@suse.de>
To: Jonathan Corbet <corbet@lwn.net>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-doc@vger.kernel.org,
Christian Borntraeger <borntraeger@de.ibm.com>
Subject: Re: [PATCH] docs: Remove space-before-label guidance from CodingStyle
Date: Thu, 22 Sep 2016 11:27:58 +0200 [thread overview]
Message-ID: <20160922112758.6fbfeffe@endymion> (raw)
In-Reply-To: <20160921155401.7acd5a47@lwn.net>
Hi Jonathan,
On Wed, 21 Sep 2016 15:54:01 -0600, Jonathan Corbet wrote:
> Recent discussion has made it clear that there is no community consensus
> on this particular rule. Remove it now, lest it inspire yet another set
> of unwanted "cleanup" patches.
>
> This partially reverts 865a1caa4b6b (CodingStyle: Clarify and complete
> chapter 7).
> (...)
> @@ -481,7 +478,7 @@ The rationale for using gotos is:
> goto out_buffer;
> }
> ...
> - out_free_buffer:
> + out_free_buffer:
> kfree(buffer);
> return result;
> }
> @@ -490,7 +487,7 @@ A common type of bug to be aware of is ``one err
> bugs`` which look like this:
> .. code-block:: c
>
> - err:
> + err:
> kfree(foo->bar);
> kfree(foo);
> return ret;
There are 2 more occurrences after this point, which you probably want
to change too.
--
Jean Delvare
SUSE L3 Support
prev parent reply other threads:[~2016-09-22 9:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-21 21:54 [PATCH] docs: Remove space-before-label guidance from CodingStyle Jonathan Corbet
2016-09-21 22:43 ` Joe Perches
2016-09-22 9:27 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160922112758.6fbfeffe@endymion \
--to=jdelvare@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.