Re: [Qemu-devel] [PATCH v4 11/17] trace: provide mechanism for registering trace events

["Daniel P. Berrange" <berrange@redhat.com>]

On Thu, Sep 22, 2016 at 02:44:11PM +0200, Lluís Vilanova wrote:
> Daniel P Berrange writes:
> 
> > Remove the notion of there being a single global array
> > of trace events, by introducing a method for registering
> > groups of events.
> 
> > Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> 
> Except for the calls to module_call_init() (I did not check if they're all
> necessary and sufficient):

Every binary that can trigger tracepoints should have the module_call_init().
I'd done it for emulators, qemu-img, qemu-nbd, and qemu-io. I could tell
which need it, since they're the ones that need to link to the trace.o
files, otherwise you'll unresolved symbol errors. So I think what I have
is correct.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|