From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2 v3] linux/tools: make it a real, separate package
Date: Thu, 22 Sep 2016 12:51:41 +0200 [thread overview]
Message-ID: <20160922125141.0a1de244@free-electrons.com> (raw)
In-Reply-To: <7af6b231b19828564aae1a098568e96e15843a62.1473171931.git.yann.morin.1998@free.fr>
Hello,
I've applied, after doing a few changes, see below.
On Tue, 6 Sep 2016 16:29:14 +0200, Yann E. MORIN wrote:
> The kernel source tree also contains the sources for various userland
> tools, of which cpupower, perf or selftests.
> +################################################################################
> +#
> +# linux-tools
> +#
> +################################################################################
> +
> +# Vampirising sources from the kernel tree, so no source nor site specified.
> +# Instead, we directly build in the sources of the linux package. We can do
> +# that, because we're not building in the same location and the same files.
> +#
> +# So, all tools refer to $(LINUX_DIR) instead of #(@D).
Typo: $(@D) instead of #(@D)
> +# Include all our tools definitions.
> +#
> +# Note: our package infrastructure uses the full-path of the last-scanned
> +# Makefile to determine what package we're currently defining, using the
> +# last directory component in the path. As such, including other Makefile,
> +# like below, before we call one of the *-package macro is usally not
> +# working.
> +# However, since the files we include here are in the same directory as
> +# the current Makefile, we are OK. But this is a hard requirement: files
> +# included here *must* be in the same directory!
> +include $(sort $(wildcard linux/linux-tools/linux-ext-*.mk))
This include path is wrong, so I've changed it to:
include $(sort $(wildcard package/linux-tools/linux-tool-*.mk))
and in fact, I fixed it in the original commit, and then realized I
messed up, so I had to fix it again in a follow-up commit.
Thanks for doing this work. Glad to see this issues fixed!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-09-22 10:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 14:29 [Buildroot] [PATCH 0/2 v3] linux/tools: move to their own package (branch yem/linux-tools) Yann E. MORIN
2016-09-06 14:29 ` [Buildroot] [PATCH 1/2 v3] linux/tools: make it a real, separate package Yann E. MORIN
2016-09-22 10:51 ` Thomas Petazzoni [this message]
2016-09-22 16:33 ` Yann E. MORIN
2016-09-22 14:58 ` Peter Korsgaard
2016-09-22 17:49 ` Thomas Petazzoni
2016-09-22 18:01 ` Peter Korsgaard
2016-09-22 18:14 ` Thomas Petazzoni
2016-09-22 18:17 ` Peter Korsgaard
2016-09-06 14:29 ` [Buildroot] [PATCH 2/2 v3] docs/manual: update the linux tools section Yann E. MORIN
2016-09-22 10:56 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160922125141.0a1de244@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.