From: "Daniel P. Berrange" <berrange@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: pbonzini@redhat.com, Lin Ma <lma@suse.com>,
qemu-devel@nongnu.org, afaerber@suse.de,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] 答复: Re: [PATCH v2] object: Add 'help' option for all available backends and properties
Date: Thu, 22 Sep 2016 14:48:54 +0100 [thread overview]
Message-ID: <20160922134854.GQ352@redhat.com> (raw)
In-Reply-To: <87a8f0i1k4.fsf@dusky.pond.sub.org>
On Thu, Sep 22, 2016 at 02:03:39PM +0200, Markus Armbruster wrote:
> "Daniel P. Berrange" <berrange@redhat.com> writes:
> >
> > IMHO we should go further and leverage QAPI schema to auto-generate all
> > the tedious boilerplate code for QOM objects
> >
> > eg, consider the crypto/secret.c object file.
> >
> > We could declare it as
> >
> > { 'object': 'QCryptoSecret',
> > 'parent': 'Object',
> > 'properties': {
> > 'format': 'QCryptoSecretFormat',
> > 'data': 'str',
> > 'file': 'str',
> > 'keyid': 'str',
> > 'iv': 'str'
> > } }
> >
> > Based on that it would have enough knowledge to generate
> >
> > - struct QCryptoSecret definition + typedef
> > - struct QCryptoSecretClass definition + typedef
> > - TYPE_CRYPTO_SECRET macro
> > - QCRYPT_SECRET() cast macro
> > - Setters & getters aka
> > qcrypto_secret_prop_set_format
> > qcrypto_secret_prop_get_format
> > qcrypto_secret_prop_set_data
> > qcrypto_secret_prop_get_data
> > qcrypto_secret_prop_set_file
> > qcrypto_secret_prop_get_file
> > qcrypto_secret_prop_set_keyid
> > qcrypto_secret_prop_get_keyid
> > qcrypto_secret_prop_set_iv
> > qcrypto_secret_prop_get_iv
> > - qcrypto_secret_finalize
> > - qcrypto_secret_class_init
> > - TypeInfo qcrypto_secret_info variable
> > - qcrypto_secret_register_types() method
> > - type_init(qcrypto_secret_register_types);
> >
> > That'd massively reduce the work to create new objects, to just
> > filling in the semantically useful logic
>
> Promising idea. Sadly, the existing QAPI queue is eating all my QAPI
> cycles.
Indeed, I've no time either. Perhaps this is something nice for a "lucky"
GSoC / OutReachy student :-) Copying Stefan....
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
next prev parent reply other threads:[~2016-09-22 13:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-11 5:53 [Qemu-devel] [PATCH v2] object: Add 'help' option for all available backends and properties Lin Ma
2016-09-12 15:42 ` Markus Armbruster
2016-09-17 12:15 ` [Qemu-devel] 答复: " Lin Ma
2016-09-19 11:58 ` Markus Armbruster
2016-09-19 15:56 ` Andreas Färber
2016-09-19 17:13 ` Markus Armbruster
2016-09-21 15:56 ` Lin Ma
2016-09-22 8:36 ` Markus Armbruster
2016-09-22 8:54 ` Daniel P. Berrange
2016-09-22 11:12 ` Markus Armbruster
2016-09-22 11:28 ` Daniel P. Berrange
2016-09-22 12:03 ` Markus Armbruster
2016-09-22 13:48 ` Daniel P. Berrange [this message]
2016-09-22 13:01 ` Daniel P. Berrange
2016-09-12 15:56 ` [Qemu-devel] " Daniel P. Berrange
2016-09-17 12:15 ` [Qemu-devel] 答复: " Lin Ma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160922134854.GQ352@redhat.com \
--to=berrange@redhat.com \
--cc=afaerber@suse.de \
--cc=armbru@redhat.com \
--cc=lma@suse.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.