From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Thu, 22 Sep 2016 20:24:19 +0000 Subject: Re: GPU-DRM-QXL: Move three assignments in qxl_device_init() Message-Id: <20160922202419.GP13620@mwanda> List-Id: References: <20160922100257.GN13620@mwanda> <45c2ad6e-fadc-8d4a-f6bd-ddf8604ec622@users.sourceforge.net> In-Reply-To: <45c2ad6e-fadc-8d4a-f6bd-ddf8604ec622@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring Cc: Bhaktipriya Shridhar , kernel-janitors@vger.kernel.org, LKML , dri-devel@lists.freedesktop.org, Julia Lawall , Daniel Vetter , Tejun Heo , Thierry Reding On Thu, Sep 22, 2016 at 03:11:25PM +0200, SF Markus Elfring wrote: > > If you restricted yourself to fixing bugs only then you would maybe fix more > > bugs than you introduce but as it you are making the kernel worse. > > Would you like to discuss the statistics for my failure (or success) rate > a bit more so that involved issues can be clarified in a constructive way? It should be that you target 20 bug fixes for each new regression that you add. Since you are just sending clean ups, every bug you introduce sets us further and further back. There is no hope for improving the kernel because you are not even trying to fix 20 bugs, only introducing them. Once you fix 20 bugs, then you will be even and you can start sending cleanups again. This is fair. regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: GPU-DRM-QXL: Move three assignments in qxl_device_init() Date: Thu, 22 Sep 2016 23:24:19 +0300 Message-ID: <20160922202419.GP13620@mwanda> References: <20160922100257.GN13620@mwanda> <45c2ad6e-fadc-8d4a-f6bd-ddf8604ec622@users.sourceforge.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from aserp1040.oracle.com (aserp1040.oracle.com [141.146.126.69]) by gabe.freedesktop.org (Postfix) with ESMTPS id C45DC6E963 for ; Thu, 22 Sep 2016 20:24:52 +0000 (UTC) Content-Disposition: inline In-Reply-To: <45c2ad6e-fadc-8d4a-f6bd-ddf8604ec622@users.sourceforge.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: SF Markus Elfring Cc: Bhaktipriya Shridhar , kernel-janitors@vger.kernel.org, LKML , dri-devel@lists.freedesktop.org, Julia Lawall , Daniel Vetter , Tejun Heo , Thierry Reding List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBTZXAgMjIsIDIwMTYgYXQgMDM6MTE6MjVQTSArMDIwMCwgU0YgTWFya3VzIEVsZnJp bmcgd3JvdGU6Cj4gPiBJZiB5b3UgcmVzdHJpY3RlZCB5b3Vyc2VsZiB0byBmaXhpbmcgYnVncyBv bmx5IHRoZW4geW91IHdvdWxkIG1heWJlIGZpeCBtb3JlCj4gPiBidWdzIHRoYW4geW91IGludHJv ZHVjZSBidXQgYXMgaXQgeW91IGFyZSBtYWtpbmcgdGhlIGtlcm5lbCB3b3JzZS4KPiAKPiBXb3Vs ZCB5b3UgbGlrZSB0byBkaXNjdXNzIHRoZSBzdGF0aXN0aWNzIGZvciBteSBmYWlsdXJlIChvciBz dWNjZXNzKSByYXRlCj4gYSBiaXQgbW9yZSBzbyB0aGF0IGludm9sdmVkIGlzc3VlcyBjYW4gYmUg Y2xhcmlmaWVkIGluIGEgY29uc3RydWN0aXZlIHdheT8KCkl0IHNob3VsZCBiZSB0aGF0IHlvdSB0 YXJnZXQgMjAgYnVnIGZpeGVzIGZvciBlYWNoIG5ldyByZWdyZXNzaW9uIHRoYXQKeW91IGFkZC4K ClNpbmNlIHlvdSBhcmUganVzdCBzZW5kaW5nIGNsZWFuIHVwcywgZXZlcnkgYnVnIHlvdSBpbnRy b2R1Y2Ugc2V0cyB1cwpmdXJ0aGVyIGFuZCBmdXJ0aGVyIGJhY2suICBUaGVyZSBpcyBubyBob3Bl IGZvciBpbXByb3ZpbmcgdGhlIGtlcm5lbApiZWNhdXNlIHlvdSBhcmUgbm90IGV2ZW4gdHJ5aW5n IHRvIGZpeCAyMCBidWdzLCBvbmx5IGludHJvZHVjaW5nIHRoZW0uCgpPbmNlIHlvdSBmaXggMjAg YnVncywgdGhlbiB5b3Ugd2lsbCBiZSBldmVuIGFuZCB5b3UgY2FuIHN0YXJ0IHNlbmRpbmcKY2xl YW51cHMgYWdhaW4uICBUaGlzIGlzIGZhaXIuCgpyZWdhcmRzLApkYW4gY2FycGVudGVyCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFp bGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030567AbcIVUZR (ORCPT ); Thu, 22 Sep 2016 16:25:17 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:19509 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934355AbcIVUZM (ORCPT ); Thu, 22 Sep 2016 16:25:12 -0400 Date: Thu, 22 Sep 2016 23:24:19 +0300 From: Dan Carpenter To: SF Markus Elfring Cc: dri-devel@lists.freedesktop.org, Bhaktipriya Shridhar , Daniel Vetter , David Airlie , Noralf =?iso-8859-1?Q?Tr=F8nnes?= , Tejun Heo , Thierry Reding , LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: GPU-DRM-QXL: Move three assignments in qxl_device_init() Message-ID: <20160922202419.GP13620@mwanda> References: <20160922100257.GN13620@mwanda> <45c2ad6e-fadc-8d4a-f6bd-ddf8604ec622@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <45c2ad6e-fadc-8d4a-f6bd-ddf8604ec622@users.sourceforge.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 22, 2016 at 03:11:25PM +0200, SF Markus Elfring wrote: > > If you restricted yourself to fixing bugs only then you would maybe fix more > > bugs than you introduce but as it you are making the kernel worse. > > Would you like to discuss the statistics for my failure (or success) rate > a bit more so that involved issues can be clarified in a constructive way? It should be that you target 20 bug fixes for each new regression that you add. Since you are just sending clean ups, every bug you introduce sets us further and further back. There is no hope for improving the kernel because you are not even trying to fix 20 bugs, only introducing them. Once you fix 20 bugs, then you will be even and you can start sending cleanups again. This is fair. regards, dan carpenter