Re: [Outreachy kernel] [PATCH] staging: wlan-ng: Edit struct member type for endianness verification

[Alison Schofield <amsfield22@gmail.com>]

On Wed, Sep 21, 2016 at 08:20:14PM -0700, Katie Dunne wrote:
> Fixes warnings found using sparse on
> drivers/staging/wlan-ng/p80211conv.c:
> warning: cast to restricted __le16
> warning: cast to restricted __be16
> 
> Updates the corresponding type in
> drivers/staging/wlan-ng/p80211conv.h

Hi Katie,

I ran sparse on p80211conv.c before the patch, and then again after
the patch and can see the sparse errors that the change cleans up.
My concern is with the ones it leaves undone and new ones added 
at line 452.

I'm guessing it's best to work this type of problem as a whole, rather
than addressing pieces of it.

I see Greg is maintainer, so look some more at those warnings and
wait and see what he says.

alisons


> 
> Signed-off-by: Katie Dunne <kdunne@mail.ccsf.edu>
> ---
>  drivers/staging/wlan-ng/p80211conv.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/p80211conv.h b/drivers/staging/wlan-ng/p80211conv.h
> index 8c10357..d8fda07 100644
> --- a/drivers/staging/wlan-ng/p80211conv.h
> +++ b/drivers/staging/wlan-ng/p80211conv.h
> @@ -130,7 +130,7 @@ struct p80211_metawep {
>  struct wlan_ethhdr {
>  	u8 daddr[ETH_ALEN];
>  	u8 saddr[ETH_ALEN];
> -	u16 type;
> +	__be16 type;
>  } __packed;
>  
>  /* local llc header type */
> @@ -143,7 +143,7 @@ struct wlan_llc {
>  /* local snap header type */
>  struct wlan_snap {
>  	u8 oui[WLAN_IEEE_OUI_LEN];
> -	u16 type;
> +	__le16 type;
>  } __packed;
>  
>  /* Circular include trick */
> -- 
> 2.7.4
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160922032014.GA31033%40katie-Inspiron-5748.
> For more options, visit https://groups.google.com/d/optout.