From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34317) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnKoG-0002xo-EU for qemu-devel@nongnu.org; Fri, 23 Sep 2016 03:22:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bnKoF-0001h5-13 for qemu-devel@nongnu.org; Fri, 23 Sep 2016 03:22:12 -0400 Received: from ozlabs.org ([103.22.144.67]:55403) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnKoE-0001gg-KJ for qemu-devel@nongnu.org; Fri, 23 Sep 2016 03:22:10 -0400 Date: Fri, 23 Sep 2016 17:22:03 +1000 From: David Gibson Message-ID: <20160923072203.GD2085@umbus.fritz.box> References: <1474606948-14391-1-git-send-email-peterx@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="yywL3DpgDyP4yZ2G" Content-Disposition: inline In-Reply-To: <1474606948-14391-1-git-send-email-peterx@redhat.com> Subject: Re: [Qemu-devel] [PATCH v7 0/3] Introduce IOMMUNotifier struct List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu Cc: qemu-devel@nongnu.org, mst@redhat.com, jasowang@redhat.com, vkaplans@redhat.com, alex.williamson@redhat.com, wexu@redhat.com, pbonzini@redhat.com, cornelia.huck@de.ibm.com, dgibson@redhat.com --yywL3DpgDyP4yZ2G Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 23, 2016 at 01:02:25PM +0800, Peter Xu wrote: > V7: > - add comments to memory_region_notify_iommu() to better clarify the > interface [David] > - vfio_iommu_map_notify(): remove pointless "IOMMUTLBEntry *iotlb =3D > data" [David] > - typo fix on English [David] >=20 > V6: > - use IOMMUTLBEntry directly for IOMMUNotifier.notify() [David] > - add explicit comment for patch 1 that CHANGE should be treated as a > MAP then an UNMAP [David] > - add a-b for David on patch 2 >=20 > V5: > - squash spapr_tce_notify_{started|stopped} into > spapr_tce_notify_flag_changed [David] > - in spapr_tce_notify_flag_changed: check flags against "!=3D > IOMMU_NOTIFIER_NONE", but not "=3D=3D IOMMU_NOTIFIER_ALL" [David] > - add r-b for David on patch 3 >=20 > V4: > - change "notifier_caps" into "notifier_flags" [David] > - rename IOMMU_NOTIFIER_{CHANGE|INVALIDATION} with MAP/UNMAP [David] > - introduce IOMMUOps.notify_flag_changed, to replace notify_started > and notify_stopped [David, Paolo] >=20 > V3: > - use QLIST instead of embedding Notifier into IOMMUNotifier [Paolo] > - fix a build error for ppc64-softmmu >=20 > The idea originates from one of Alex's reply: >=20 > https://lists.gnu.org/archive/html/qemu-devel/2016-09/msg00254.html >=20 > But after further discussions, it seems that only adding a simple type > for notifier is not enough. This series introduced IOMMUNotifier > struct to replace the old Notifier interface. Along with it, we can > provide registration for one (or multiple) of the IOMMU notifications: >=20 > - cache invalidations > - entry changes >=20 > This is a support material for Jason's vhost dmar patchset. >=20 > Please read commit messages for detailed information. Thanks, I think we're ready to go with this. I still think 3/3 is premature, but I don't care that much. Peter, thanks for your patience with my nitpicking of the interface. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --yywL3DpgDyP4yZ2G Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJX5NgbAAoJEGw4ysog2bOS43UP/3cZvT9e5BmZ+VKvanXus1H+ AbjBeFwmn/TL0UGCfWd5P3+id9oedYTC7iC5kgeA/e6HHWA3FnTM2GfmQUPF6GAX wpCQ1kunuBynsihoRnE/5GPu+tUEvHLpZBc+qmyEOr/DJrHRqIm9IF1Q1tdWX03a NWmv9aQfQMQskp7+MCUiwPR2cX4KJ0EhxKhKXnAYYCALn78NHa5SXkC6tAT14dnq DBeUoQnwey1OYZwbmLv32WsNEAOc6o9nUF7DFKzO8321jUNaZ2lTOKU/cJ1ZaOgQ bLbsHHNezTaUQgWoz09tVmIkv6ojZjbqn4zjE/+qAHMQMpopMZgmde1qBX/QbzOa e1NlvkOqDjBPOdVPORPNoznaTFXapUVf+cZq9ZX0D/2uPh2Whj04rkzuRPMwctCY KEGRdbFbnv22DvHDTsCmccx0VjtJtxUTgjFYnLYe3gqq7KGNAutQssMkUBg4+Geg 9Pwoslo0t/42Di1nFXrAqMMf0tmw5HN4uuFDC7y2GRXid6VcoiXy7Va8/0WyyyhA obq/AuDRxSqHFRuUgqZuAxMxoTYML9c1NOW6tg9qY0xarToC/xSX/bGDAlk9shGz mS72kgnaJ1POGCo/BhQhBAzSkS6Yp9aUft676Ivmcejyf6sWm4PsUM1ZiBZjzNnT zODlhEYhTbdfXF59P/wi =qrpa -----END PGP SIGNATURE----- --yywL3DpgDyP4yZ2G--