All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] qt5: Disable pkg-config usage for cross-building
Date: Fri, 23 Sep 2016 07:57:22 +0200	[thread overview]
Message-ID: <20160923075722.3dbee0a8@free-electrons.com> (raw)
In-Reply-To: <20160922205817.GC3179@free.fr>

Hello,

On Thu, 22 Sep 2016 22:58:17 +0200, Yann E. MORIN wrote:

> I have not paid much attention to the previous discussion on the topic.
> 
> However, I think disabling use of pkg-config is wrong. That is qmake
> that is at fault here because, from what I understood from the previous
> discussion, it emits -isystem where it should not.
> 
> So qmake needs to be fixed to not emit -isystem in those conditions.
> 
> Removing the use of pkg-config is just papering over the real problem.
> 
> Usually, using pkg-config solves more issues than not using it.
> 
> So, I am not very happy with this patch, to say the least... :-(

I entirely agree with Yann. Disabling pkg-config is clearly not the
solution we want to use.

Alexey, have you tried the other approaches I outlined in the thread
where the initial discussion took place?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2016-09-23  5:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-22 19:48 [Buildroot] [PATCH] qt5: Disable pkg-config usage for cross-building Alexey Brodkin
2016-09-22 20:58 ` Yann E. MORIN
2016-09-23  5:57   ` Thomas Petazzoni [this message]
2016-09-23  6:12     ` Alexey Brodkin
2016-09-23  6:19       ` Thomas Petazzoni
2016-09-23  7:28         ` Alexey Brodkin
2016-09-23  9:38           ` Alexey Brodkin
2016-09-24  6:05             ` Fabián Inostroza

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160923075722.3dbee0a8@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.