All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org, David Marchand <david.marchand@6wind.com>,
	"Tan, Jianfeng" <jianfeng.tan@intel.com>
Subject: Re: [PATCH] eal: remove single file segments related code
Date: Fri, 23 Sep 2016 17:14:48 +0800	[thread overview]
Message-ID: <20160923091448.GB23158@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <3786074.FTf50R74LC@xps13>

On Fri, Sep 23, 2016 at 10:50:06AM +0200, Thomas Monjalon wrote:
> 2016-09-23 15:10, Yuanhan Liu:
> > Commit c711ccb30987 ("ivshmem: remove library and its EAL integration")
> > removed ivshmem support, but seems David forgot to remove the another
> > piece of code: code for RTE_EAL_SINGLE_FILE_SEGMENTS, which is introduced
> > when ivshmem was firstly added.
> 
> It is not a mistake. We thought it is used by container use case.

I think no. It would help the container case a bit, but not too much I
would think, especially when the memory goes fragement.

Jianfeng, IIRC, you don't use that option for container case, right?

	--yliu

  reply	other threads:[~2016-09-23  9:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-23  7:10 [PATCH] eal: remove single file segments related code Yuanhan Liu
2016-09-23  8:50 ` Thomas Monjalon
2016-09-23  9:14   ` Yuanhan Liu [this message]
2016-09-23 10:08     ` Tan, Jianfeng
2016-09-30 14:32       ` David Marchand
2016-09-30 14:48         ` Sergio Gonzalez Monroy
2016-10-03 14:08           ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160923091448.GB23158@yliu-dev.sh.intel.com \
    --to=yuanhan.liu@linux.intel.com \
    --cc=david.marchand@6wind.com \
    --cc=dev@dpdk.org \
    --cc=jianfeng.tan@intel.com \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.