From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1034149AbcIWMGu (ORCPT ); Fri, 23 Sep 2016 08:06:50 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:52503 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965837AbcIWMGr (ORCPT ); Fri, 23 Sep 2016 08:06:47 -0400 Date: Fri, 23 Sep 2016 14:06:52 +0200 From: Greg KH To: Yannis Damigos Cc: markus.boehme@mailbox.org, devel@driverdev.osuosl.org, arve@android.com, riandrews@android.com, linux-kernel@vger.kernel.org Subject: Re: [PATCHv3 5/5] staging:android:ion: Remove empty release function Message-ID: <20160923120652.GA25375@kroah.com> References: <20160923084439.GA32459@kroah.com> <20160923095015.12720-1-giannis.damigos@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160923095015.12720-1-giannis.damigos@gmail.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 23, 2016 at 12:50:15PM +0300, Yannis Damigos wrote: > This patch removes the empty function rmem_ion_device_release > > Signed-off-by: Yannis Damigos > --- > drivers/staging/android/ion/ion_of.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/staging/android/ion/ion_of.c b/drivers/staging/android/ion/ion_of.c > index 49f052c..91c0642 100644 > --- a/drivers/staging/android/ion/ion_of.c > +++ b/drivers/staging/android/ion/ion_of.c > @@ -158,15 +158,8 @@ static int rmem_ion_device_init(struct reserved_mem *rmem, struct device *dev) > return 0; > } > > -static void rmem_ion_device_release(struct reserved_mem *rmem, > - struct device *dev) > -{ > - return; > -} > - > static const struct reserved_mem_ops rmem_dma_ops = { > .device_init = rmem_ion_device_init, > - .device_release = rmem_ion_device_release, > }; > > static int __init rmem_ion_setup(struct reserved_mem *rmem) > -- > 2.10.0 Have you tested that this works? thanks, greg k-h