From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Mikulas Patocka <mpatocka@redhat.com>,
hpa@zytor.com, josh@joshtriplett.org, rostedt@goodmis.org,
mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com,
torvalds@linux-foundation.org, mingo@kernel.org,
tglx@linutronix.de, linux-kernel@vger.kernel.org,
oleg@redhat.com, linux-tip-commits@vger.kernel.org
Subject: Re: [tip:sched/core] sched/core: Avoid _cond_resched() for PREEMPT=y
Date: Fri, 23 Sep 2016 07:47:08 -0700 [thread overview]
Message-ID: <20160923144708.GC14933@linux.vnet.ibm.com> (raw)
In-Reply-To: <20160923084442.GC5008@twins.programming.kicks-ass.net>
On Fri, Sep 23, 2016 at 10:44:42AM +0200, Peter Zijlstra wrote:
> On Thu, Sep 22, 2016 at 01:28:17PM -0700, Paul E. McKenney wrote:
> > On Thu, Sep 22, 2016 at 08:42:28PM +0200, Peter Zijlstra wrote:
> > > On Thu, Sep 22, 2016 at 02:25:01PM -0400, Mikulas Patocka wrote:
> > > > I've found a document that says that cond_resched() is needed on
> > > > preemptible kernels to mark RCU quiescent states:
> > > >
> > > > https://lwn.net/Articles/603252/
> > > >
> > > > Paul, is cond_resched() still needed on current RCU implementation? Or not?
> > >
> > > No, we ripped that out. See 4a81e8328d37 ("rcu: Reduce overhead of
> > > cond_resched() checks for RCU")
> >
> > I would instead say that we changed the algorithm to reduce the overhead
> > in the common case, but yes, this commit did change things quite a bit.
>
> Sure, but critical point (for this discussion) is that cond_resched() no
> longer implies anything RCU, it really only is a voluntary reschedule
> point.
Agreed, cond_resched_rcu_qs() is what you use to do both a cond_resched()
and an RCU quiescent state.
Thanx, Paul
prev parent reply other threads:[~2016-09-23 14:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tip-35a773a07926a22bf19d77ee00024522279c4e68@git.kernel.org>
2016-09-22 18:25 ` [tip:sched/core] sched/core: Avoid _cond_resched() for PREEMPT=y Mikulas Patocka
2016-09-22 18:30 ` Paul E. McKenney
2016-09-22 18:42 ` Peter Zijlstra
2016-09-22 20:28 ` Paul E. McKenney
2016-09-23 8:44 ` Peter Zijlstra
2016-09-23 14:47 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160923144708.GC14933@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=hpa@zytor.com \
--cc=jiangshanlai@gmail.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@kernel.org \
--cc=mpatocka@redhat.com \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.