From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1035068AbcIWPGi (ORCPT ); Fri, 23 Sep 2016 11:06:38 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:33854 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1034048AbcIWPGh (ORCPT ); Fri, 23 Sep 2016 11:06:37 -0400 Date: Fri, 23 Sep 2016 17:06:42 +0200 From: Greg KH To: Yannis Damigos Cc: devel@driverdev.osuosl.org, arve@android.com, riandrews@android.com, linux-kernel@vger.kernel.org Subject: Re: [PATCHv2 3/5] staging:android:ion: Fix blank line issues Message-ID: <20160923150642.GA13933@kroah.com> References: <20160923080517.421-1-giannis.damigos@gmail.com> <20160923080517.421-3-giannis.damigos@gmail.com> <20160923121744.GC21575@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 23, 2016 at 04:26:28PM +0300, Yannis Damigos wrote: > On Fri, Sep 23, 2016 at 3:17 PM, Greg KH wrote: > > On Fri, Sep 23, 2016 at 11:05:15AM +0300, giannis.damigos@gmail.com wrote: > >> From: Yannis Damigos > >> > >> This patch fixes the following blank line issues: > >> > >> CHECK: Please don't use multiple blank lines > >> + > >> + > > > > What does that mean with the + + lines? > > > >> > >> CHECK: Please use a blank line after function/struct/union/enum > >> declarations > >> +} > >> +RESERVEDMEM_OF_DECLARE(ion, "ion-region", rmem_ion_setup); > > > > Linewrap :( > > > If the line is not wrapped, I get the following warning: > Possible unwrapped commit description (prefer a maximum 75 chars per line) > > Should I ignore it? Don't you think it makes sense to do so? :)