From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1035248AbcIWPIe (ORCPT ); Fri, 23 Sep 2016 11:08:34 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:33896 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1034980AbcIWPIb (ORCPT ); Fri, 23 Sep 2016 11:08:31 -0400 Date: Fri, 23 Sep 2016 17:08:37 +0200 From: Greg KH To: Baoyou Xie Cc: mathias.nyman@intel.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@arndb.de, xie.baoyou@linaro.org, xie.baoyou@zte.com.cn Subject: Re: [PATCH] usb: xhci: mark xhci_unmap_td_bounce_buffer() static Message-ID: <20160923150837.GC13933@kroah.com> References: <1474638373-27342-1-git-send-email-baoyou.xie@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1474638373-27342-1-git-send-email-baoyou.xie@linaro.org> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 23, 2016 at 09:46:13PM +0800, Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/usb/host/xhci-ring.c:608:6: warning: no previous prototype for 'xhci_unmap_td_bounce_buffer' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which it is > declared and don't need a declaration, but can be made static. > so this patch marks this function with 'static'. Any reason you aren't using sparse for all of these 'static' functions you are finding? It should be easier than using 'W=1'. thanks, greg k-h