Re: [PATCH v2] staging: wilc1000: Remove 'else' after 'break'

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Sat, Sep 24, 2016 at 05:28:16PM +0530, Namrata A Shettar wrote:
> Remove 'else' after 'break' to resolve checkpatch issue.
> The statements after the 'if' condition body are executed only if
> condition not true due to the 'break'.
> 
> Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
> ---
>  Changes in v2:
>  - Code indentation
> 
>  drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> index 05e4501..042185d 100644
> --- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> +++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> @@ -695,11 +695,8 @@ static int connect(struct wiphy *wiphy, struct net_device *dev,
>  			   sme->ssid_len) == 0) {
>  			if (!sme->bssid)
>  				break;
> -			else
> -			        if (memcmp(last_scanned_shadow[i].bssid,
> -							sme->bssid,
> -						       	ETH_ALEN) == 0)
> -			                              break;
> +			if (memcmp(last_scanned_shadow[i].bssid,sme->bssid,ETH_ALEN) == 0)
> +			        break;
>  		}
>  	}
>  
> -- 
> 2.7.4

Always run your patches through checkpatch.pl so you don't get a grumpy
maintainer telling you to run your patches through checkpatch.pl...