From: Jean Delvare <jdelvare@suse.de>
To: Joe Perches <joe@perches.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Chaoming Li <chaoming_li@realsil.com.cn>,
Kalle Valo <kvalo@codeaurora.org>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages
Date: Sat, 24 Sep 2016 17:55:55 +0200 [thread overview]
Message-ID: <20160924175555.01cae6dd@endymion> (raw)
In-Reply-To: <1474657363.1849.9.camel@perches.com>
Hi Joe, Larry,
On Fri, 23 Sep 2016 12:02:43 -0700, Joe Perches wrote:
> On Fri, 2016-09-23 at 13:59 -0500, Larry Finger wrote:
> > I'm not familiar with the %#x format. What does it do?
>
> Outputs SPECIAL prefix, it's the same as "0x%x"
>
> lib/vsprintf.c:
> #define SPECIAL 64 /* prefix hex with "0x", octal with "0" */
Is hexadecimal actually the best way to display these values? I guess it
depends how they are listed in the datasheets (if there's anything like
that for these chips?)
I found it a bit difficult to look up the meaning of the value.
HAL_DEF_WOWLAN is an enum value, the number is not set and there's no
comment. I had to count the line numbers, taking blank lines into
account... I ended up pasting the whole enum to a random C file and
printing the value of HAL_DEF_WOWLAN to make sure it was 92.
Would it make sense to explicitly set the enum values, or add them as
comments, to make such look-ups easier?
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2016-09-24 15:56 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-22 9:51 rtl8192ce:rtl92ce_get_hw_reg():<0-0> switch case not processed Jean Delvare
2016-09-22 15:09 ` Larry Finger
2016-09-22 17:05 ` Jean Delvare
2016-09-22 21:01 ` Jean Delvare
2016-09-23 12:16 ` Jean Delvare
2016-09-23 18:10 ` Larry Finger
2016-09-24 15:25 ` Jean Delvare
2016-09-23 18:12 ` Joe Perches
2016-09-23 18:27 ` [PATCH] realtek: Add switch variable to 'switch case not processed' messages Joe Perches
2016-09-23 18:59 ` Larry Finger
2016-09-23 19:02 ` Joe Perches
2016-09-24 15:55 ` Jean Delvare [this message]
2016-09-24 16:15 ` Joe Perches
2016-09-24 16:35 ` Larry Finger
2016-09-24 17:32 ` Joe Perches
2016-09-24 19:06 ` Larry Finger
2016-09-24 20:02 ` Jes Sorensen
2016-09-24 20:29 ` Joe Perches
2016-09-24 20:35 ` Jes Sorensen
2016-09-26 9:33 ` David Laight
2016-09-23 19:07 ` Larry Finger
2016-09-23 19:07 ` Larry Finger
2016-09-27 15:45 ` rtlwifi: " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160924175555.01cae6dd@endymion \
--to=jdelvare@suse.de \
--cc=Larry.Finger@lwfinger.net \
--cc=chaoming_li@realsil.com.cn \
--cc=joe@perches.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.