From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59933)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1bnxdA-0000Rk-QV
	for qemu-devel@nongnu.org; Sat, 24 Sep 2016 20:49:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1bnxd6-0006fs-Mc
	for qemu-devel@nongnu.org; Sat, 24 Sep 2016 20:49:19 -0400
Received: from mx1.redhat.com ([209.132.183.28]:34746)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1bnxd6-0006fb-GT
	for qemu-devel@nongnu.org; Sat, 24 Sep 2016 20:49:16 -0400
Date: Sun, 25 Sep 2016 03:49:13 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20160925034836-mutt-send-email-mst@kernel.org>
References: <1474658051-18617-1-git-send-email-mst@redhat.com>
	<20160923203527.227108.81665@ex-std-node742.prod.rhcloud.com>
	<20160924010453-mutt-send-email-mst@kernel.org>
	<efd2bb58-a1d9-48b6-26da-2bec98bab3cf@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <efd2bb58-a1d9-48b6-26da-2bec98bab3cf@redhat.com>
Subject: Re: [Qemu-devel] [PULL 00/19] virtio, pc: fixes and features
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org, famz@redhat.com

On Sat, Sep 24, 2016 at 06:10:37PM +0200, Paolo Bonzini wrote:
> 
> 
> On 24/09/2016 00:05, Michael S. Tsirkin wrote:
> >> e events...
> >> > Checking PATCH 18/19: hw/i386: Introduce AMD IOMMU...
> >> > ERROR: struct MemoryRegionIOMMUOps should normally be const
> >> > #1527: FILE: hw/i386/amd_iommu.h:280:
> >> > +    MemoryRegionIOMMUOps iommu_ops;
> > 
> > False positive.
> 
> Not quite, there's no reason for the ops to be inside AMDVIState rather
> than a (static) global.
> 
> Paolo

I guess but it's a logic refactoring, not merely a style one.
I feel we can do it on top, tool shouldn't require this.