From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf-next] netfilter: evict stale entries when user reads /proc/net/nf_conntrack
Date: Sun, 25 Sep 2016 13:47:01 +0200 [thread overview]
Message-ID: <20160925114701.GA8623@salvia> (raw)
In-Reply-To: <1474580957-26032-1-git-send-email-fw@strlen.de>
On Thu, Sep 22, 2016 at 11:49:17PM +0200, Florian Westphal wrote:
> Fabian reports a possible conntrack memory leak (could not reproduce so
> far), however, one minor issue can be easily resolved:
>
> > cat /proc/net/nf_conntrack | wc -l = 5
> > 4 minutes required to clean up the table.
>
> We should not report those timed-out entries to the user in first place.
> And instead of just skipping those timed-out entries while iterating over
> the table we can also zap them (we already do this during ctnetlink
> walks, but I forgot about the /proc interface).
>
> Fixes: f330a7fdbe16 ("netfilter: conntrack: get rid of conntrack timer")
> Reported-by: Fabian Frederick <fabf@skynet.be>
> Signed-off-by: Florian Westphal <fw@strlen.de>
Applied, thanks.
prev parent reply other threads:[~2016-09-25 11:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-22 21:49 [PATCH nf-next] netfilter: evict stale entries when user reads /proc/net/nf_conntrack Florian Westphal
2016-09-25 11:47 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160925114701.GA8623@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.