From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gustavo Padovan Subject: Re: [PATCH] dma-buf/sw_sync: mark sync_timeline_create() static Date: Sun, 25 Sep 2016 22:33:13 +0200 Message-ID: <20160925203313.GA2571@joana> References: <1474202961-10099-1-git-send-email-baoyou.xie@linaro.org> <20160920111338.GE13275@joana> <20160922065731.GA16298@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5D2426E258 for ; Sun, 25 Sep 2016 20:33:16 +0000 (UTC) Received: by mail-wm0-f67.google.com with SMTP id w84so11192960wmg.0 for ; Sun, 25 Sep 2016 13:33:16 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20160922065731.GA16298@kroah.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Greg Kroah-Hartman Cc: Arnd Bergmann , xie.baoyou@zte.com.cn, LKML , DRI mailing list , Linaro MM SIG Mailman List , Baoyou Xie , "linux-media@vger.kernel.org" List-Id: dri-devel@lists.freedesktop.org SGkgQmFveW91LAoKMjAxNi0wOS0yMiBHcmVnIEtyb2FoLUhhcnRtYW4gPGdyZWdraEBsaW51eGZv dW5kYXRpb24ub3JnPjoKCj4gT24gVHVlLCBTZXAgMjAsIDIwMTYgYXQgMDY6MjM6MzNQTSArMDUz MCwgU3VtaXQgU2Vtd2FsIHdyb3RlOgo+ID4gSGkgQmFveW91LAo+ID4gCj4gPiBPbiAyMCBTZXB0 ZW1iZXIgMjAxNiBhdCAxNjo0MywgR3VzdGF2byBQYWRvdmFuIDxndXN0YXZvQHBhZG92YW4ub3Jn PiB3cm90ZToKPiA+ID4gMjAxNi0wOS0xOCBCYW95b3UgWGllIDxiYW95b3UueGllQGxpbmFyby5v cmc+Ogo+ID4gPgo+ID4gPj4gV2UgZ2V0IDEgd2FybmluZyB3aGVuIGJ1aWxkaW5nIGtlcm5lbCB3 aXRoIFc9MToKPiA+ID4+IGRyaXZlcnMvZG1hLWJ1Zi9zd19zeW5jLmM6ODc6MjM6IHdhcm5pbmc6 IG5vIHByZXZpb3VzIHByb3RvdHlwZSBmb3IgJ3N5bmNfdGltZWxpbmVfY3JlYXRlJyBbLVdtaXNz aW5nLXByb3RvdHlwZXNdCj4gPiA+Pgo+ID4gPj4gSW4gZmFjdCwgdGhpcyBmdW5jdGlvbiBpcyBv bmx5IHVzZWQgaW4gdGhlIGZpbGUgaW4gd2hpY2ggaXQgaXMKPiA+ID4+IGRlY2xhcmVkIGFuZCBk b24ndCBuZWVkIGEgZGVjbGFyYXRpb24sIGJ1dCBjYW4gYmUgbWFkZSBzdGF0aWMuCj4gPiA+PiBT byB0aGlzIHBhdGNoIG1hcmtzIGl0ICdzdGF0aWMnLgo+ID4gPj4KPiA+ID4+IFNpZ25lZC1vZmYt Ynk6IEJhb3lvdSBYaWUgPGJhb3lvdS54aWVAbGluYXJvLm9yZz4KPiA+ID4+IC0tLQo+ID4gPj4g IGRyaXZlcnMvZG1hLWJ1Zi9zd19zeW5jLmMgfCAyICstCj4gPiA+PiAgMSBmaWxlIGNoYW5nZWQs IDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4gPiA+Cj4gPiA+IFRoYW5rcyBmb3IgZmlu ZGluZyB0aGlzLgo+ID4gCj4gPiBUaGFua3MgZm9yIHRoZSBwYXRjaDsgdGhpcyBkb2Vzbid0IGFw cGx5IHRvIG1haW5saW5lIHlldCwgc2luY2UgdGhlCj4gPiBkZS1zdGFnaW5nIG9mIHN3X3N5bmMg Y29kZSBpcyBxdWV1ZWQgZm9yIDQuOSB2aWEgR3JlZy1LSCdzIHRyZWUuCj4gPiBDQydpbmcgaGlt Lgo+ID4gCj4gPiBHcmVnLCB3b3VsZCBpdCBiZSBwb3NzaWJsZSB0byBwbGVhc2UgdGFrZSB0aGlz IHZpYSB5b3VyIHRyZWU/Cj4gCj4gSWYgc29tZW9uZSByZXNlbmRzIGl0IHRvIG1lIHdpdGggdGhl IG5lZWRlZCBhY2tzIGFuZCByZXZpZXdlZC1ieSwgSQo+IHdpbGwuCgpDb3VsZCBwbGVhc2UgcmVz ZW5kIHRoaXMgdG8gR3JlZyB3aXRoIGFsbCB0aGUgYWNrcyBhbmQgcmV2aWV3ZWQtYnkgaW4KdGhl IGNvbW1pdCBtZXNzYWdlPyBUaGFua3MuCgpHdXN0YXZvCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZl bEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wm0-f65.google.com ([74.125.82.65]:36134 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759810AbcIYUdQ (ORCPT ); Sun, 25 Sep 2016 16:33:16 -0400 Date: Sun, 25 Sep 2016 22:33:13 +0200 From: Gustavo Padovan To: Greg Kroah-Hartman Cc: Sumit Semwal , Baoyou Xie , Arnd Bergmann , xie.baoyou@zte.com.cn, LKML , DRI mailing list , Linaro MM SIG Mailman List , "linux-media@vger.kernel.org" Subject: Re: [PATCH] dma-buf/sw_sync: mark sync_timeline_create() static Message-ID: <20160925203313.GA2571@joana> References: <1474202961-10099-1-git-send-email-baoyou.xie@linaro.org> <20160920111338.GE13275@joana> <20160922065731.GA16298@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160922065731.GA16298@kroah.com> Sender: linux-media-owner@vger.kernel.org List-ID: Hi Baoyou, 2016-09-22 Greg Kroah-Hartman : > On Tue, Sep 20, 2016 at 06:23:33PM +0530, Sumit Semwal wrote: > > Hi Baoyou, > > > > On 20 September 2016 at 16:43, Gustavo Padovan wrote: > > > 2016-09-18 Baoyou Xie : > > > > > >> We get 1 warning when building kernel with W=1: > > >> drivers/dma-buf/sw_sync.c:87:23: warning: no previous prototype for 'sync_timeline_create' [-Wmissing-prototypes] > > >> > > >> In fact, this function is only used in the file in which it is > > >> declared and don't need a declaration, but can be made static. > > >> So this patch marks it 'static'. > > >> > > >> Signed-off-by: Baoyou Xie > > >> --- > > >> drivers/dma-buf/sw_sync.c | 2 +- > > >> 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > Thanks for finding this. > > > > Thanks for the patch; this doesn't apply to mainline yet, since the > > de-staging of sw_sync code is queued for 4.9 via Greg-KH's tree. > > CC'ing him. > > > > Greg, would it be possible to please take this via your tree? > > If someone resends it to me with the needed acks and reviewed-by, I > will. Could please resend this to Greg with all the acks and reviewed-by in the commit message? Thanks. Gustavo