From: Dave Chinner <david@fromorbit.com>
To: Sudip Midya <midya.sudip@gmail.com>
Cc: xfs@oss.sgi.com, hch@infradead.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] mm: remove unnecessary rcu_lock/unlock around radix_tree_tagged lockless function. The function queue_delayed_work is already protected with interrupts disabled, hence no need to add rcu_lock/unlock.
Date: Mon, 26 Sep 2016 07:45:24 +1000 [thread overview]
Message-ID: <20160925214524.GS340@dastard> (raw)
In-Reply-To: <20160925192005.GA6517@sudip-Dell-System-Vostro-3450>
On Mon, Sep 26, 2016 at 12:50:06AM +0530, Sudip Midya wrote:
> Signed-off-by: Sudip Midya <midya.sudip@gmail.com>
> ---
Patch format still needs work. The subject line should be short, the
patch description should be in the body of the message, not the
subject. Also, this is not a patch for the "mm" subsystem.
Addressing the reason given for the change: the RCU lock is not
actually protecting queue_delayed_work(), so while the code change
may be OK, the reason given for removing it is not. So why is it
safe to remove the rcu_read_lock()?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2016-09-25 21:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-25 19:20 [PATCH] mm: remove unnecessary rcu_lock/unlock around radix_tree_tagged lockless function. The function queue_delayed_work is already protected with interrupts disabled, hence no need to add rcu_lock/unlock Sudip Midya
2016-09-25 21:45 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160925214524.GS340@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=midya.sudip@gmail.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.