From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Date: Mon, 26 Sep 2016 01:14:09 +0200 Subject: [Intel-wired-lan] [PATCH] igb: mark igb_rxnfc_write_vlan_prio_filter() static In-Reply-To: <1474842217.2751.6.camel@intel.com> References: <1474783558-7384-1-git-send-email-baoyou.xie@linaro.org> <1474842217.2751.6.camel@intel.com> Message-ID: <201609260114.10052.arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: On Monday 26 September 2016, Jeff Kirsher wrote: > On Sun, 2016-09-25 at 14:05 +0800, Baoyou Xie wrote: > > We get 1 warning when building kernel with W=1: > > drivers/net/ethernet/intel/igb/igb_ethtool.c:2707:5: warning: no previous > > prototype for 'igb_rxnfc_write_vlan_prio_filter' [-Wmissing-prototypes] > > > > In fact, this function is only used in the file in which it is > > declared and don't need a declaration, but can be made static. > > so this patch marks this function with 'static'. > > > > Signed-off-by: Baoyou Xie > > --- > > drivers/net/ethernet/intel/igb/igb_ethtool.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > This has been fixed as well, and there is already a patch. Baoyou, I've seen you do this on other patches as well, please make sure it doesn't happen again, and keep track of which patches you have already sent out. It can sometimes happen that a patch gets dropped by accident, but none of the changes you sent so far are important enough to warrant resending for the same kernel release. If a patch got posted multiple weeks before the merge window and still has not made it into linux-next by the time the following -rc2 release is out, you can resend it, but then it should be marked in the subject line, e.g. [PATCH RESEND], and an explanation below the '---' line why it got resent. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941197AbcIYXOx (ORCPT ); Sun, 25 Sep 2016 19:14:53 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:51373 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S941106AbcIYXOt (ORCPT ); Sun, 25 Sep 2016 19:14:49 -0400 From: Arnd Bergmann To: Jeff Kirsher Subject: Re: [PATCH] igb: mark igb_rxnfc_write_vlan_prio_filter() static Date: Mon, 26 Sep 2016 01:14:09 +0200 User-Agent: KMail/1.12.2 (Linux/4.7.0-rc7+; KDE/4.3.2; x86_64; ; ) Cc: Baoyou Xie , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, xie.baoyou@zte.com.cn References: <1474783558-7384-1-git-send-email-baoyou.xie@linaro.org> <1474842217.2751.6.camel@intel.com> In-Reply-To: <1474842217.2751.6.camel@intel.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201609260114.10052.arnd@arndb.de> X-Provags-ID: V03:K0:h9Zs7n7lJaYbkfnE3rTgqTRzSUnh1tpVmpNt0CRR2jDvutfuh04 ss9kH1MaPjw0UpthOF9YfhlUxSgmHKsIHEnKYstTVLxlgkRUkBcj0wKtnSudFrL9IVIGtgx Vo5PVQ6plkO0ed0EmNfcTCqam+LY8ty7KoxCaZcWvHK6M+fHepUoJLYksRr3TXMRM4zCNAd h9WKQF3s5IdQrsZHqQ5xw== X-UI-Out-Filterresults: notjunk:1;V01:K0:WbRurl9vDGM=:tl+s3LTa5hiljMOswIa0tb TGE3T8UA5g9SRp0jHTn1o2UcIqkgHxWzyXeYobOBWn4/2xm32EhpR0StcUPgCblOnnyt0I4Uf XkT6ToZql58VwfiEqsM2+AxLpdzBwXy+sChwmEmZ5l7U30xAbpwUxunJroCE9NYFLLhWWWuOg HYXDsWw9vkknCkTzZFg2uR2xubjt1xaIeyqkVw57riBAP1p5ioWgVHLh+PCbnVEnVMcYiEsO3 BTMELHe8dY33GeqDVC58HgIiidlgR6gj6wdbC7JakMA62GRHj75KoG6qtd+KMr7ZDeynWQsXd 6td4Pg7rL6p55kWZ+IulQMMVBhNl/mybRZEBzFf6I6VK+3DBWfj5xGwAMsvlZaRkgALZu05GQ IDWDRfF6bYtVIAhH6jHc6cwEsSe0U35/jIKvpubNrD/is7MD9zky72fv9r8WNXbFRXNhMALDt E0KbF10W+o0WXOun/d/wFfav1Ey9+g0OXDIOyRNSTFwyaDHsYTC3z2zVqLnEoWYyxqK70HCW4 OChxrFXUp0uTrfJNws6HpGiLfGU8TO27v7Uj7rCed5L1mrz+cL0UhbM0aP/nZoxU1QG3lFJF1 kmjAwxAZedDKp8kIAD9DrqY9xxOLOBHAzw1mGcN9HYHeMzwrSKxGa2pEormFeX5k6zi6VAz6i WFhok0KuvUrjv8dPAgX2draHwZ9m5WyeOzrbj7x80Pf+7wTUOMb1xjwh0QyKRnP+hL2qu1fFw Bay3bOzNBCeZ7SPHbc8LrMRasZuINh06HhYUjw== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 26 September 2016, Jeff Kirsher wrote: > On Sun, 2016-09-25 at 14:05 +0800, Baoyou Xie wrote: > > We get 1 warning when building kernel with W=1: > > drivers/net/ethernet/intel/igb/igb_ethtool.c:2707:5: warning: no previous > > prototype for 'igb_rxnfc_write_vlan_prio_filter' [-Wmissing-prototypes] > > > > In fact, this function is only used in the file in which it is > > declared and don't need a declaration, but can be made static. > > so this patch marks this function with 'static'. > > > > Signed-off-by: Baoyou Xie > > --- > > drivers/net/ethernet/intel/igb/igb_ethtool.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > This has been fixed as well, and there is already a patch. Baoyou, I've seen you do this on other patches as well, please make sure it doesn't happen again, and keep track of which patches you have already sent out. It can sometimes happen that a patch gets dropped by accident, but none of the changes you sent so far are important enough to warrant resending for the same kernel release. If a patch got posted multiple weeks before the merge window and still has not made it into linux-next by the time the following -rc2 release is out, you can resend it, but then it should be marked in the subject line, e.g. [PATCH RESEND], and an explanation below the '---' line why it got resent. Arnd