From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941163AbcIYXaJ (ORCPT ); Sun, 25 Sep 2016 19:30:09 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:58632 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751950AbcIYXaH (ORCPT ); Sun, 25 Sep 2016 19:30:07 -0400 From: Arnd Bergmann To: Baoyou Xie Subject: Re: [PATCH 1/2] mfd: ab8500-debugfs: add function declaration Date: Mon, 26 Sep 2016 01:29:41 +0200 User-Agent: KMail/1.12.2 (Linux/4.7.0-rc7+; KDE/4.3.2; x86_64; ; ) Cc: Lee Jones , Linux Kernel Mailing List , xie.baoyou@zte.com.cn, tang.qiang007@zte.com.cn, han.fei@zte.com.cn References: <1474695290-21619-1-git-send-email-baoyou.xie@linaro.org> <5669860.khWdu6PIDc@wuerfel> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201609260129.41684.arnd@arndb.de> X-Provags-ID: V03:K0:tyxX/1G6aK8Zi06WQuaoLdcmRg1tgmrTZy8SQxiV7EbIk0iW9vH OMYDaL23nJ5i1JTDfzgxH+/w6N8FEiT3USlkXhKTyWLes+kPe0AVvlFcmZbp7aGUkfDIZzk p1RQ5O2FdkvteoES9gu3p/RabJEMrAvSDNclxO79A+VeEs17wX30iY8/zSrBLC7uALChRLG Y/aIBMZpFq2RrA6IAXXmw== X-UI-Out-Filterresults: notjunk:1;V01:K0:a0oPKj4kNxE=:sijJUkh/HgezKFeoofUVwQ kzG1jtbzlhBmICWqkVNE9MAfhevfZfTBUDzjZaRSbuAqI/HSt2Gi3heeA/h2YJXbxsn+lqQxi vd34exP3ipIlbZkDhMccX+/Gr9hfBHp0UWn10Nd8fL1r1Gjjg++UpJj2NrlDZiRChh38ZZFoS VdKuVudk+1slHdZpwQ9NWaS7MbTSWc0yr3EEXJFbGDmRSDbNMypyVeW2NYWtGUBRt6XlUlHMw t/5kObHYZWIi1G4hkvldmSOl+X11DyG1QIl2kDSNJ7Obl3j/2vnxg7LXVtDUHSYn40rkYoFZI gGhQ5gkW9PKOs56r10aSeZjusGu1ebw79wuTMmfJGz2fNBc9BnoAzPLGTeqcYVzfSGw8tUO2V /8JlNuphM/tkCsMpzLqmp0QcGH3KQeZ9KPeCDo2AceR3SMV+r6JYe/9na/ACjHY7MDz2Gxla0 VLmdNzucX5ajfHdie/L48MEMxfDHt1M0FC7/GSHzkPWBw61q0AgTZVcMgAxPntKXzXFwDQQt5 H4T0TNp1K4b16M+FNCMbsO2XgjUn6u4S1x0ZP5n/UswMHP7Pcx/Nm0KWFEZ7n5efHFjXGjYbZ l5po2Hz+xrzAUbhZtdCrc3Sq4goXhS34UBMO4zQV+0GUbjkZD+TMyrfDwe2Yv87xvMIgWcO6T 925uoDM0HQ89rITvpDHUfD/mk3Kj+UJBLq0Tlb7Cu2S/EVmoNPCurrCDH/6PuGmpbNVEKrLom TF7Mw/s3M1pJlzMMOJjoi+ehpHvqE0qqPc93Eg== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday 25 September 2016, Baoyou Xie wrote: > On 24 September 2016 at 16:30, Arnd Bergmann wrote: > > > > This can't be right for two reasons: > > > > - the suspend_test_wake_cause_interrupt_is_mine function again > > is only used in the file it is defined in > > > > but, it is declared as weak, so other modules can implement it. In theory that is correct, but doing that would be very unusual and bad style. As nobody does this at the moment, and the driver is for obsolete hardware, just remove it now, and if we ever need want to override it, that should be done using a runtime callback handler or something completely different. Arnd