From: Lin Ma <lma@suse.com>
To: qemu-devel@nongnu.org
Cc: afaerber@suse.de, armbru@redhat.com, berrange@redhat.com,
pbonzini@redhat.com
Subject: [Qemu-devel] [PATCH v3 2/3] qapi: auto generate enum value strings
Date: Mon, 26 Sep 2016 18:16:26 +0800 [thread overview]
Message-ID: <20160926101627.14296-3-lma@suse.com> (raw)
In-Reply-To: <20160926101627.14296-1-lma@suse.com>
Automatically generate enum value strings that containing the acceptable values.
(Borrowwed Daniel's code.)
Signed-off-by: Lin Ma <lma@suse.com>
---
scripts/qapi-types.py | 2 ++
scripts/qapi.py | 9 +++++++++
2 files changed, 11 insertions(+)
diff --git a/scripts/qapi-types.py b/scripts/qapi-types.py
index dabc42e..0446839 100644
--- a/scripts/qapi-types.py
+++ b/scripts/qapi-types.py
@@ -202,9 +202,11 @@ class QAPISchemaGenTypeVisitor(QAPISchemaVisitor):
self._btin += gen_enum(name, values, prefix)
if do_builtins:
self.defn += gen_enum_lookup(name, values, prefix)
+ self._btin += gen_enum_value_str(name, values)
else:
self._fwdecl += gen_enum(name, values, prefix)
self.defn += gen_enum_lookup(name, values, prefix)
+ self._fwdecl += gen_enum_value_str(name, values)
def visit_array_type(self, name, info, element_type):
if isinstance(element_type, QAPISchemaBuiltinType):
diff --git a/scripts/qapi.py b/scripts/qapi.py
index 21bc32f..d11c414 100644
--- a/scripts/qapi.py
+++ b/scripts/qapi.py
@@ -1649,6 +1649,15 @@ const char *const %(c_name)s_lookup[] = {
return ret
+def gen_enum_value_str(name, values):
+ return mcgen('''
+
+#define %(c_name)s_value_str "%(value_str)s"
+''',
+ c_name=c_name(name),
+ value_str=", ".join(["'%s'" % c for c in values]))
+
+
def gen_enum(name, values, prefix=None):
# append automatically generated _MAX value
enum_values = values + ['_MAX']
--
2.9.2
next prev parent reply other threads:[~2016-09-26 10:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-26 10:16 [Qemu-devel] [PATCH v3 0/3] object: Add 'help' option for all available backends and properties Lin Ma
2016-09-26 10:16 ` [Qemu-devel] [PATCH v3 1/3] qom: make base type user-creatable abstract Lin Ma
2016-09-26 10:37 ` Daniel P. Berrange
2016-10-10 14:32 ` [Qemu-devel] 答复: " Lin Ma
2016-10-10 14:45 ` Paolo Bonzini
2016-10-10 15:01 ` Daniel P. Berrange
2016-10-10 16:37 ` Paolo Bonzini
2016-09-26 10:16 ` Lin Ma [this message]
2016-09-26 10:38 ` [Qemu-devel] [PATCH v3 2/3] qapi: auto generate enum value strings Daniel P. Berrange
2016-09-26 20:17 ` Eric Blake
2016-10-10 15:09 ` [Qemu-devel] 答复: " Lin Ma
2016-10-10 19:00 ` Eric Blake
2016-10-11 6:56 ` Markus Armbruster
2016-10-13 10:02 ` Lin Ma
2016-09-26 10:16 ` [Qemu-devel] [PATCH v3 3/3] object: Add 'help' option for all available backends and properties Lin Ma
2016-09-26 10:41 ` Daniel P. Berrange
2016-10-10 14:38 ` [Qemu-devel] 答复: " Lin Ma
2016-09-26 10:34 ` [Qemu-devel] [PATCH v3 0/3] " no-reply
2016-09-26 10:39 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160926101627.14296-3-lma@suse.com \
--to=lma@suse.com \
--cc=afaerber@suse.de \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.