From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56590) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1boTHZ-0003cg-MY for qemu-devel@nongnu.org; Mon, 26 Sep 2016 06:37:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1boTHY-0005Gx-BQ for qemu-devel@nongnu.org; Mon, 26 Sep 2016 06:37:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62433) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1boTHY-0005Gm-5q for qemu-devel@nongnu.org; Mon, 26 Sep 2016 06:37:08 -0400 Date: Mon, 26 Sep 2016 11:37:04 +0100 From: "Daniel P. Berrange" Message-ID: <20160926103703.GF18393@redhat.com> Reply-To: "Daniel P. Berrange" References: <20160926101627.14296-1-lma@suse.com> <20160926101627.14296-2-lma@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160926101627.14296-2-lma@suse.com> Subject: Re: [Qemu-devel] [PATCH v3 1/3] qom: make base type user-creatable abstract List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lin Ma Cc: qemu-devel@nongnu.org, afaerber@suse.de, armbru@redhat.com, pbonzini@redhat.com On Mon, Sep 26, 2016 at 06:16:25PM +0800, Lin Ma wrote: > Signed-off-by: Lin Ma > --- > qom/object_interfaces.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/qom/object_interfaces.c b/qom/object_interfaces.c > index bf59846..9288242 100644 > --- a/qom/object_interfaces.c > +++ b/qom/object_interfaces.c > @@ -217,6 +217,7 @@ static void register_types(void) > static const TypeInfo uc_interface_info = { > .name = TYPE_USER_CREATABLE, > .parent = TYPE_INTERFACE, > + .abstract = true, > .class_size = sizeof(UserCreatableClass), > }; This doesn't make any conceptual sense. UserCreatable is an inteface and by definition all interfaces are abstract. Were you trying to fix some particular real bug here ? If so, we almost certainly need a different fix to what's suggested here, because QOM should automatically treat all interfaces as abstract by their very nature. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|