From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57026) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1boTJS-0005LT-Cs for qemu-devel@nongnu.org; Mon, 26 Sep 2016 06:39:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1boTJO-0005ow-Md for qemu-devel@nongnu.org; Mon, 26 Sep 2016 06:39:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38192) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1boTJO-0005on-Gc for qemu-devel@nongnu.org; Mon, 26 Sep 2016 06:39:02 -0400 Date: Mon, 26 Sep 2016 11:38:56 +0100 From: "Daniel P. Berrange" Message-ID: <20160926103856.GG18393@redhat.com> Reply-To: "Daniel P. Berrange" References: <20160926101627.14296-1-lma@suse.com> <20160926101627.14296-3-lma@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160926101627.14296-3-lma@suse.com> Subject: Re: [Qemu-devel] [PATCH v3 2/3] qapi: auto generate enum value strings List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lin Ma Cc: qemu-devel@nongnu.org, afaerber@suse.de, armbru@redhat.com, pbonzini@redhat.com On Mon, Sep 26, 2016 at 06:16:26PM +0800, Lin Ma wrote: > Automatically generate enum value strings that containing the acceptable values. > (Borrowwed Daniel's code.) > > Signed-off-by: Lin Ma > --- > scripts/qapi-types.py | 2 ++ > scripts/qapi.py | 9 +++++++++ > 2 files changed, 11 insertions(+) This will need some test case coverage in tests/ somewhere, but I'm not sure exactly which place is best - Eric/Markus can probably advise Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|