From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57750) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1boTM5-0007fv-Rs for qemu-devel@nongnu.org; Mon, 26 Sep 2016 06:41:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1boTM4-0006mg-LQ for qemu-devel@nongnu.org; Mon, 26 Sep 2016 06:41:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60586) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1boTM4-0006mW-Eb for qemu-devel@nongnu.org; Mon, 26 Sep 2016 06:41:48 -0400 Date: Mon, 26 Sep 2016 11:41:44 +0100 From: "Daniel P. Berrange" Message-ID: <20160926104144.GH18393@redhat.com> Reply-To: "Daniel P. Berrange" References: <20160926101627.14296-1-lma@suse.com> <20160926101627.14296-4-lma@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160926101627.14296-4-lma@suse.com> Subject: Re: [Qemu-devel] [PATCH v3 3/3] object: Add 'help' option for all available backends and properties List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lin Ma Cc: qemu-devel@nongnu.org, afaerber@suse.de, armbru@redhat.com, pbonzini@redhat.com On Mon, Sep 26, 2016 at 06:16:27PM +0800, Lin Ma wrote: > '-object help' prints available user creatable backends. > '-object $typename,help' prints relevant properties. > > Signed-off-by: Lin Ma > --- > backends/hostmem.c | 4 ++++ > crypto/secret.c | 4 ++++ > crypto/tlscreds.c | 4 ++++ > include/qom/object_interfaces.h | 2 ++ > net/filter.c | 4 ++++ > qemu-options.hx | 7 +++++- > qom/object_interfaces.c | 48 +++++++++++++++++++++++++++++++++++++++++ > vl.c | 5 +++++ > 8 files changed, 77 insertions(+), 1 deletion(-) > > diff --git a/backends/hostmem.c b/backends/hostmem.c > index b7a208d..eea9dce 100644 > --- a/backends/hostmem.c > +++ b/backends/hostmem.c > @@ -261,6 +261,10 @@ static void host_memory_backend_init(Object *obj) > HostMemPolicy_lookup, > host_memory_backend_get_policy, > host_memory_backend_set_policy, NULL); > + object_property_set_description(obj, "policy", > + "Data format: one of " > + HostMemPolicy_value_str, > + &error_abort); > } > Adding descriptions to properties should be done separately from your impl of help printing, as they're independant concepts. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|