Re: [PATCH] staging: vt6656: Remove unneccesary return variable

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Mon, Sep 26, 2016 at 04:42:03PM +0530, Namrata A Shettar wrote:
> Remove uneccessary return variable 'ret'. Return value directly.
> 
> Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
> ---
>  drivers/staging/vt6656/card.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/vt6656/card.c b/drivers/staging/vt6656/card.c
> index 53b469c..33de99a 100644
> --- a/drivers/staging/vt6656/card.c
> +++ b/drivers/staging/vt6656/card.c
> @@ -708,8 +708,6 @@ void vnt_update_next_tbtt(struct vnt_private *priv, u64 tsf,
>   */
>  int vnt_radio_power_off(struct vnt_private *priv)
>  {
> -	int ret = true;
> -
>  	switch (priv->rf_type) {
>  	case RF_AL2230:
>  	case RF_AL2230S:
> @@ -728,7 +726,7 @@ int vnt_radio_power_off(struct vnt_private *priv)
>  
>  	vnt_mac_reg_bits_on(priv, MAC_REG_GPIOCTL1, GPIO3_INTMD);
>  
> -	return ret;
> +	return true;
>  }

If this function can never "fail", why return anything at all?  Just
make the function not return anything, it's not like the return value is
even checked.

>  
>  /*
> @@ -745,8 +743,6 @@ int vnt_radio_power_off(struct vnt_private *priv)
>   */
>  int vnt_radio_power_on(struct vnt_private *priv)
>  {
> -	int ret = true;
> -
>  	vnt_exit_deep_sleep(priv);
>  
>  	vnt_mac_reg_bits_on(priv, MAC_REG_HOSTCR, HOSTCR_RXON);
> @@ -765,7 +761,7 @@ int vnt_radio_power_on(struct vnt_private *priv)
>  
>  	vnt_mac_reg_bits_off(priv, MAC_REG_GPIOCTL1, GPIO3_INTMD);
>  
> -	return ret;
> +	return true;
>  }
i
Same here.

thanks,

greg k-h